diff options
| author | Sarven Capadisli <csarven@status.net> | 2009-12-02 23:13:15 +0100 |
|---|---|---|
| committer | Sarven Capadisli <csarven@status.net> | 2009-12-02 23:13:15 +0100 |
| commit | 7b550f386a8a3f38ced8ee587d7ae1c997e97906 (patch) | |
| tree | 4715c03fb2e99de62a12be5c109e2a203e2e266a | |
| parent | 5f0c6f3eaabe0faa40b6d76e158e77d1cd707c8c (diff) | |
If the page doesn't have .notices, silently skip the notice XHR response
| -rw-r--r-- | js/util.js | 62 |
1 files changed, 33 insertions, 29 deletions
diff --git a/js/util.js b/js/util.js index 9ffbd88e4..3c9c3986a 100644 --- a/js/util.js +++ b/js/util.js @@ -214,37 +214,41 @@ var SN = { // StatusNet self.close(); } - if ($('#'+SN.C.S.CommandResult, data).length > 0) { - result = document._importNode($('p', data)[0], true); - result = result.textContent || result.innerHTML; - form.append('<p class="success">'+result+'</p>'); - } - else { - notice = document._importNode($('li', data)[0], true); - if ($('#'+notice.id).length === 0) { - var notice_irt_value = $('#'+SN.C.S.NoticeInReplyTo).val(); - var notice_irt = '#notices_primary #notice-'+notice_irt_value; - if($('body')[0].id == 'conversation') { - if(notice_irt_value.length > 0 && $(notice_irt+' .notices').length < 1) { - $(notice_irt).append('<ul class="notices"></ul>'); + var notices = $("#notices_primary .notices"); + + if (notices.length > 0) { + if ($('#'+SN.C.S.CommandResult, data).length > 0) { + result = document._importNode($('p', data)[0], true); + result = result.textContent || result.innerHTML; + form.append('<p class="success">'+result+'</p>'); + } + else { + notice = document._importNode($('li', data)[0], true); + if ($('#'+notice.id).length === 0) { + var notice_irt_value = $('#'+SN.C.S.NoticeInReplyTo).val(); + var notice_irt = '#notices_primary #notice-'+notice_irt_value; + if($('body')[0].id == 'conversation') { + if(notice_irt_value.length > 0 && $(notice_irt+' .notices').length < 1) { + $(notice_irt).append('<ul class="notices"></ul>'); + } + $($(notice_irt+' .notices')[0]).append(notice); + } + else { + notices.prepend(notice); } - $($(notice_irt+' .notices')[0]).append(notice); - } - else { - $("#notices_primary .notices").prepend(notice); - } - $('#'+notice.id).css({display:'none'}); - $('#'+notice.id).fadeIn(2500); - SN.U.NoticeWithAttachment($('#'+notice.id)); - SN.U.NoticeReplyTo($('#'+notice.id)); - SN.U.FormXHR($('#'+notice.id+' .form_favor')); - } + $('#'+notice.id).css({display:'none'}); + $('#'+notice.id).fadeIn(2500); + SN.U.NoticeWithAttachment($('#'+notice.id)); + SN.U.NoticeReplyTo($('#'+notice.id)); + SN.U.FormXHR($('#'+notice.id+' .form_favor')); + } + } + $('#'+form_id+' #'+SN.C.S.NoticeDataText).val(''); + $('#'+form_id+' #'+SN.C.S.NoticeDataAttach).val(''); + $('#'+form_id+' #'+SN.C.S.NoticeInReplyTo).val(''); + $('#'+form_id+' #'+SN.C.S.NoticeDataAttachSelected).remove(); + SN.U.FormNoticeEnhancements($('#'+form_id)); } - $('#'+form_id+' #'+SN.C.S.NoticeDataText).val(''); - $('#'+form_id+' #'+SN.C.S.NoticeDataAttach).val(''); - $('#'+form_id+' #'+SN.C.S.NoticeInReplyTo).val(''); - $('#'+form_id+' #'+SN.C.S.NoticeDataAttachSelected).remove(); - SN.U.FormNoticeEnhancements($('#'+form_id)); } }, complete: function(xhr, textStatus) { |