Merge branch 'master' of /var/www/trunk

29 files changed, 190 insertions, 67 deletions

diff --git a/actions/accesstoken.php b/actions/accesstoken.php
index 65c67c64e..77fdf6aef 100644
--- a/actions/accesstoken.php
+++ b/actions/accesstoken.php
@@ -50,7 +50,7 @@ class AccesstokenAction extends Action
      * Class handler.
      *
      * @param array $args query arguments
-     * 
+     *
      * @return boolean false if user doesn't exist
      */
     function handle($args)
diff --git a/actions/allrss.php b/actions/allrss.php
index 248f59f43..05787f3f7 100644
--- a/actions/allrss.php
+++ b/actions/allrss.php
@@ -123,5 +123,10 @@ class AllrssAction extends Rss10Action
         $avatar = $profile->getAvatar(AVATAR_PROFILE_SIZE);
         return $avatar ? $avatar->url : null;
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/api.php b/actions/api.php
index dfe2c8857..21fe4eea3 100644
--- a/actions/api.php
+++ b/actions/api.php
@@ -162,12 +162,12 @@ class ApiAction extends Action
 
         if ($this->content_type == 'xml') {
             header('Content-Type: application/xml; charset=utf-8');
-            common_start_xml();
+            $this->startXML();
             $this->elementStart('hash');
             $this->element('error', null, $msg);
             $this->element('request', null, $_SERVER['REQUEST_URI']);
             $this->elementEnd('hash');
-            common_end_xml();
+            $this->endXML();
         } else if ($this->content_type == 'json')  {
             header('Content-Type: application/json; charset=utf-8');
             $error_array = array('error' => $msg, 'request' => $_SERVER['REQUEST_URI']);
diff --git a/actions/avatarbynickname.php b/actions/avatarbynickname.php
index fec202016..9bbdecefa 100644
--- a/actions/avatarbynickname.php
+++ b/actions/avatarbynickname.php
@@ -97,5 +97,10 @@ class AvatarbynicknameAction extends Action
         }
         common_redirect($url, 302);
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/doc.php b/actions/doc.php
index 3755bb051..6957659ad 100644
--- a/actions/doc.php
+++ b/actions/doc.php
@@ -107,4 +107,9 @@ class DocAction extends Action
     {
         return ucfirst($this->title);
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
diff --git a/actions/favoritesrss.php b/actions/favoritesrss.php
index 19339325c..ad72dce9e 100644
--- a/actions/favoritesrss.php
+++ b/actions/favoritesrss.php
@@ -114,5 +114,10 @@ class FavoritesrssAction extends Rss10Action
     {
         return null;
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/groups.php b/actions/groups.php
index 261f9b3aa..39dc2232b 100644
--- a/actions/groups.php
+++ b/actions/groups.php
@@ -51,6 +51,11 @@ class GroupsAction extends Action
     var $page = null;
     var $profile = null;
 
+    function isReadOnly()
+    {
+        return true;
+    }
+
     function title()
     {
         if ($this->page == 1) {
diff --git a/actions/groupsearch.php b/actions/groupsearch.php
index 66f5c87b3..9b0026db9 100644
--- a/actions/groupsearch.php
+++ b/actions/groupsearch.php
@@ -103,5 +103,10 @@ class GroupSearchResults extends GroupList
     {
         return preg_replace($this->pattern, '<strong>\\1</strong>', htmlspecialchars($text));
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/logout.php b/actions/logout.php
index 0ff8dc754..3977f90a0 100644
--- a/actions/logout.php
+++ b/actions/logout.php
@@ -54,7 +54,7 @@ class LogoutAction extends Action
      */
     function isReadOnly()
     {
-        return true;
+        return false;
     }
 
     /**
diff --git a/actions/microsummary.php b/actions/microsummary.php
index 196dd5de8..065a2e0eb 100644
--- a/actions/microsummary.php
+++ b/actions/microsummary.php
@@ -73,4 +73,9 @@ class MicrosummaryAction extends Action
         
         print $user->nickname . ': ' . $notice->content;
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
diff --git a/actions/noticesearch.php b/actions/noticesearch.php
index 8c5128de1..3c3fdca9f 100644
--- a/actions/noticesearch.php
+++ b/actions/noticesearch.php
@@ -222,5 +222,10 @@ class NoticesearchAction extends SearchAction
         } while ($count);
         return $result;
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/noticesearchrss.php b/actions/noticesearchrss.php
index c1a1c2c67..7172977ee 100644
--- a/actions/noticesearchrss.php
+++ b/actions/noticesearchrss.php
@@ -95,4 +95,9 @@ class NoticesearchrssAction extends Rss10Action
     {
         return null;
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
diff --git a/actions/nudge.php b/actions/nudge.php
index ca6fd3761..ca7947f5a 100644
--- a/actions/nudge.php
+++ b/actions/nudge.php
@@ -122,5 +122,10 @@ class NudgeAction extends Action
             // XXX: notify by SMS
         }
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/openidlogin.php b/actions/openidlogin.php
index ec5361c8b..7a267a2bd 100644
--- a/actions/openidlogin.php
+++ b/actions/openidlogin.php
@@ -90,16 +90,27 @@ class OpenidloginAction extends Action
     function showContent() {
         $formaction = common_local_url('openidlogin');
         $this->elementStart('form', array('method' => 'post',
-                                           'id' => 'openidlogin',
+                                           'id' => 'form_openid_login',
+                                           'class' => 'form_settings',
                                            'action' => $formaction));
+        $this->elementStart('fieldset');
+        $this->element('legend', null, _('OpenID login'));
         $this->hidden('token', common_session_token());
+
+        $this->elementStart('ul', 'form_data');
+        $this->elementStart('li');
         $this->input('openid_url', _('OpenID URL'),
                      $this->openid_url,
                      _('Your OpenID URL'));
+        $this->elementEnd('li');
+        $this->elementStart('li', array('id' => 'settings_rememberme'));
         $this->checkbox('rememberme', _('Remember me'), false,
                         _('Automatically login in the future; ' .
                            'not for shared computers!'));
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
         $this->submit('submit', _('Login'));
+        $this->elementEnd('fieldset');
         $this->elementEnd('form');
     }
 
diff --git a/actions/opensearch.php b/actions/opensearch.php
index d7705972f..7709249bb 100644
--- a/actions/opensearch.php
+++ b/actions/opensearch.php
@@ -83,5 +83,10 @@ class OpensearchAction extends Action
         $this->elementEnd('OpenSearchDescription');
         common_end_xml();
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/peoplesearch.php b/actions/peoplesearch.php
index 3c672c940..615201c46 100644
--- a/actions/peoplesearch.php
+++ b/actions/peoplesearch.php
@@ -109,5 +109,10 @@ class PeopleSearchResults extends ProfileList
     {
         return preg_replace($this->pattern, '<strong>\\1</strong>', htmlspecialchars($text));
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/public.php b/actions/public.php
index f5380589a..cfdc99bb3 100644
--- a/actions/public.php
+++ b/actions/public.php
@@ -56,6 +56,11 @@ class PublicAction extends Action
 
     var $page = null;
 
+    function isReadOnly()
+    {
+        return true;
+    }
+
     /**
      * Read and validate arguments
      *
@@ -200,8 +205,8 @@ class PublicAction extends Action
 
     function showSections()
     {
-        $top = new TopPostersSection($this);
-        $top->show();
+        // $top = new TopPostersSection($this);
+        // $top->show();
         $pop = new PopularNoticeSection($this);
         $pop->show();
         $gbp = new GroupsByPostsSection($this);
diff --git a/actions/publicrss.php b/actions/publicrss.php
index 844c334be..c35877997 100644
--- a/actions/publicrss.php
+++ b/actions/publicrss.php
@@ -102,5 +102,10 @@ class PublicrssAction extends Rss10Action
     {
         // nop
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/actions/replies.php b/actions/replies.php
index ea8ef4764..5777d17fd 100644
--- a/actions/replies.php
+++ b/actions/replies.php
@@ -191,4 +191,9 @@ class RepliesAction extends Action
                           $this->page, 'replies',
                           array('nickname' => $this->user->nickname));
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
diff --git a/actions/repliesrss.php b/actions/repliesrss.php
index 48c4fa255..985318bf1 100644
--- a/actions/repliesrss.php
+++ b/actions/repliesrss.php
@@ -82,4 +82,9 @@ class RepliesrssAction extends Rss10Action
         $avatar = $profile->getAvatar(AVATAR_PROFILE_SIZE);
         return ($avatar) ? $avatar->url : null;
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
diff --git a/actions/showmessage.php b/actions/showmessage.php
index 289414153..572a71739 100644
--- a/actions/showmessage.php
+++ b/actions/showmessage.php
@@ -176,4 +176,9 @@ class ShowmessageAction extends MailboxAction
     {
         return '';
     }
-}
\ No newline at end of file
+
+    function isReadOnly()
+    {
+        return true;
+    }
+}
diff --git a/actions/showstream.php b/actions/showstream.php
index 2fd56ad2e..c1ef8ba52 100644
--- a/actions/showstream.php
+++ b/actions/showstream.php
@@ -60,6 +60,11 @@ class ShowstreamAction extends Action
     var $page = null;
     var $profile = null;
 
+    function isReadOnly()
+    {
+        return true;
+    }
+
     function title()
     {
         if ($this->page == 1) {
diff --git a/actions/subscribers.php b/actions/subscribers.php
index be9df2b12..fb8733c77 100644
--- a/actions/subscribers.php
+++ b/actions/subscribers.php
@@ -103,4 +103,9 @@ class SubscribersList extends ProfileList
                                   'nickname' => $this->owner->nickname));
         $bf->show();
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
diff --git a/actions/tagrss.php b/actions/tagrss.php
index b0227ab39..b4c2dcdff 100644
--- a/actions/tagrss.php
+++ b/actions/tagrss.php
@@ -66,4 +66,9 @@ class TagrssAction extends Rss10Action
                'description' => sprintf(_('Microblog tagged with %s'), $tagname));
         return $c;
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
diff --git a/actions/usergroups.php b/actions/usergroups.php
index 20f2e5a75..748585e1d 100644
--- a/actions/usergroups.php
+++ b/actions/usergroups.php
@@ -52,6 +52,11 @@ class UsergroupsAction extends Action
     var $page = null;
     var $profile = null;
 
+    function isReadOnly()
+    {
+        return true;
+    }
+
     function title()
     {
         if ($this->page == 1) {
diff --git a/actions/userrss.php b/actions/userrss.php
index c1f2321ee..04855ccca 100644
--- a/actions/userrss.php
+++ b/actions/userrss.php
@@ -94,5 +94,10 @@ class UserrssAction extends Rss10Action
         header('X-SUP-ID: '.$url);
         parent::initRss($limit);
     }
+
+    function isReadOnly()
+    {
+        return true;
+    }
 }
 
diff --git a/lib/logingroupnav.php b/lib/logingroupnav.php
index 8c03eccea..fd909581f 100644
--- a/lib/logingroupnav.php
+++ b/lib/logingroupnav.php
@@ -77,7 +77,7 @@ class LoginGroupNav extends Widget
                 'register' =>
                 array(_('Register'),
                       _('Sign up for a new account')),
-                'openid' =>
+                'openidlogin' =>
                 array(_('OpenID'),
                       _('Login or register with OpenID')));
 
diff --git a/lib/twitterapi.php b/lib/twitterapi.php
index 3d2c74feb..da8b8b1e5 100644
--- a/lib/twitterapi.php
+++ b/lib/twitterapi.php
@@ -28,7 +28,7 @@ class TwitterapiAction extends Action
     {
         parent::handle($args);
     }
-
+    
     function twitter_user_array($profile, $get_notice=false)
     {
 
@@ -158,56 +158,56 @@ class TwitterapiAction extends Action
 
     function show_twitter_xml_status($twitter_status)
     {
-        common_element_start('status');
+        $this->elementStart('status');
         foreach($twitter_status as $element => $value) {
             switch ($element) {
             case 'user':
                 $this->show_twitter_xml_user($twitter_status['user']);
                 break;
             case 'text':
-                common_element($element, null, common_xml_safe_str($value));
+                $this->element($element, null, common_xml_safe_str($value));
                 break;
             default:
-                common_element($element, null, $value);
+                $this->element($element, null, $value);
             }
         }
-        common_element_end('status');
+        $this->elementEnd('status');
     }
 
     function show_twitter_xml_user($twitter_user, $role='user')
     {
-        common_element_start($role);
+        $this->elementStart($role);
         foreach($twitter_user as $element => $value) {
             if ($element == 'status') {
                 $this->show_twitter_xml_status($twitter_user['status']);
             } else {
-                common_element($element, null, $value);
+                $this->element($element, null, $value);
             }
         }
-        common_element_end($role);
+        $this->elementEnd($role);
     }
 
     function show_twitter_rss_item($entry)
     {
-        common_element_start('item');
-        common_element('title', null, $entry['title']);
-        common_element('description', null, $entry['description']);
-        common_element('pubDate', null, $entry['pubDate']);
-        common_element('guid', null, $entry['guid']);
-        common_element('link', null, $entry['link']);
-        common_element_end('item');
+        $this->elementStart('item');
+        $this->element('title', null, $entry['title']);
+        $this->element('description', null, $entry['description']);
+        $this->element('pubDate', null, $entry['pubDate']);
+        $this->element('guid', null, $entry['guid']);
+        $this->element('link', null, $entry['link']);
+        $this->elementEnd('item');
     }
 
     function show_twitter_atom_entry($entry)
     {
-        common_element_start('entry');
-        common_element('title', null, $entry['title']);
-        common_element('content', array('type' => 'html'), $entry['content']);
-        common_element('id', null, $entry['id']);
-        common_element('published', null, $entry['published']);
-        common_element('updated', null, $entry['updated']);
-        common_element('link', array('href' => $entry['link'], 'rel' => 'alternate', 'type' => 'text/html'), null);
-        common_element_end('entry');
+        $this->elementStart('entry');
+        $this->element('title', null, $entry['title']);
+        $this->element('content', array('type' => 'html'), $entry['content']);
+        $this->element('id', null, $entry['id']);
+        $this->element('published', null, $entry['published']);
+        $this->element('updated', null, $entry['updated']);
+        $this->element('link', array('href' => $entry['link'], 'rel' => 'alternate', 'type' => 'text/html'), null);
+        $this->elementEnd('entry');
     }
 
     function show_json_objects($objects)
@@ -249,7 +249,7 @@ class TwitterapiAction extends Action
 
     function show_twitter_xml_dmsg($twitter_dm)
     {
-        common_element_start('direct_message');
+        $this->elementStart('direct_message');
         foreach($twitter_dm as $element => $value) {
             switch ($element) {
             case 'sender':
@@ -257,20 +257,20 @@ class TwitterapiAction extends Action
                 $this->show_twitter_xml_user($value, $element);
                 break;
             case 'text':
-                common_element($element, null, common_xml_safe_str($value));
+                $this->element($element, null, common_xml_safe_str($value));
                 break;
             default:
-                common_element($element, null, $value);
+                $this->element($element, null, $value);
             }
         }
-        common_element_end('direct_message');
+        $this->elementEnd('direct_message');
     }
 
     function show_xml_timeline($notice)
     {
 
         $this->init_document('xml');
-        common_element_start('statuses', array('type' => 'array'));
+        $this->elementStart('statuses', array('type' => 'array'));
 
         if (is_array($notice)) {
             foreach ($notice as $n) {
@@ -284,7 +284,7 @@ class TwitterapiAction extends Action
             }
         }
 
-        common_element_end('statuses');
+        $this->elementEnd('statuses');
         $this->end_document('xml');
     }
 
@@ -293,19 +293,19 @@ class TwitterapiAction extends Action
 
         $this->init_document('rss');
 
-        common_element_start('channel');
-        common_element('title', null, $title);
-        common_element('link', null, $link);
+        $this->elementStart('channel');
+        $this->element('title', null, $title);
+        $this->element('link', null, $link);
         if (!is_null($suplink)) {
             # For FriendFeed's SUP protocol
-            common_element('link', array('xmlns' => 'http://www.w3.org/2005/Atom',
+            $this->element('link', array('xmlns' => 'http://www.w3.org/2005/Atom',
                                          'rel' => 'http://api.friendfeed.com/2008/03#sup',
                                          'href' => $suplink,
                                          'type' => 'application/json'));
         }
-        common_element('description', null, $subtitle);
-        common_element('language', null, 'en-us');
-        common_element('ttl', null, '40');
+        $this->element('description', null, $subtitle);
+        $this->element('language', null, 'en-us');
+        $this->element('ttl', null, '40');
 
         if (is_array($notice)) {
             foreach ($notice as $n) {
@@ -319,7 +319,7 @@ class TwitterapiAction extends Action
             }
         }
 
-        common_element_end('channel');
+        $this->elementEnd('channel');
         $this->end_twitter_rss();
     }
 
@@ -328,16 +328,16 @@ class TwitterapiAction extends Action
 
         $this->init_document('atom');
 
-        common_element('title', null, $title);
-        common_element('id', null, $id);
-        common_element('link', array('href' => $link, 'rel' => 'alternate', 'type' => 'text/html'), null);
+        $this->element('title', null, $title);
+        $this->element('id', null, $id);
+        $this->element('link', array('href' => $link, 'rel' => 'alternate', 'type' => 'text/html'), null);
         if (!is_null($suplink)) {
             # For FriendFeed's SUP protocol
-            common_element('link', array('rel' => 'http://api.friendfeed.com/2008/03#sup',
+            $this->element('link', array('rel' => 'http://api.friendfeed.com/2008/03#sup',
                                          'href' => $suplink,
                                          'type' => 'application/json'));
         }
-        common_element('subtitle', null, $subtitle);
+        $this->element('subtitle', null, $subtitle);
 
         if (is_array($notice)) {
             foreach ($notice as $n) {
@@ -425,7 +425,7 @@ class TwitterapiAction extends Action
         switch ($type) {
          case 'xml':
             header('Content-Type: application/xml; charset=utf-8');
-            common_start_xml();
+            $this->startXML();
             break;
          case 'json':
             header('Content-Type: application/json; charset=utf-8');
@@ -456,7 +456,7 @@ class TwitterapiAction extends Action
     {
         switch ($type) {
          case 'xml':
-            common_end_xml();
+            $this->endXML();
             break;
          case 'json':
 
@@ -514,10 +514,10 @@ class TwitterapiAction extends Action
 
         if ($content_type == 'xml') {
             $this->init_document('xml');
-            common_element_start('hash');
-            common_element('error', null, $msg);
-            common_element('request', null, $_SERVER['REQUEST_URI']);
-            common_element_end('hash');
+            $this->elementStart('hash');
+            $this->element('error', null, $msg);
+            $this->element('request', null, $_SERVER['REQUEST_URI']);
+            $this->elementEnd('hash');
             $this->end_document('xml');
         } else {
             $this->init_document('json');
@@ -530,26 +530,26 @@ class TwitterapiAction extends Action
 
     function init_twitter_rss()
     {
-        common_start_xml();
-        common_element_start('rss', array('version' => '2.0'));
+        $this->startXML();
+        $this->elementStart('rss', array('version' => '2.0'));
     }
 
     function end_twitter_rss()
     {
-        common_element_end('rss');
-        common_end_xml();
+        $this->elementEnd('rss');
+        $this->endXML();
     }
 
     function init_twitter_atom()
     {
-        common_start_xml();
-        common_element_start('feed', array('xmlns' => 'http://www.w3.org/2005/Atom', 'xml:lang' => 'en-US'));
+        $this->startXML();
+        $this->elementStart('feed', array('xmlns' => 'http://www.w3.org/2005/Atom', 'xml:lang' => 'en-US'));
     }
 
     function end_twitter_atom()
     {
-        common_end_xml();
-        common_element_end('feed');
+        $this->endXML();
+        $this->elementEnd('feed');
     }
 
     function show_profile($profile, $content_type='xml', $notice=null)
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index 24f5cc865..f8dbd7941 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -145,7 +145,8 @@ font-weight:bold;
 #newgroup legend,
 #editgroup legend,
 #form_tag_user legend,
-#form_remote_subscribe legend {
+#form_remote_subscribe legend,
+#form_openid_login legend {
 display:none;
 }
 
@@ -173,7 +174,8 @@ width:90%;
 }
 
 #form_login p.form_guide,
-#form_register #settings_rememberme p.form_guide {
+#form_register #settings_rememberme p.form_guide,
+#form_openid_login #settings_rememberme p.form_guide {
 margin-left:0;
 }