diff options
| author | Brion Vibber <brion@pobox.com> | 2009-10-13 16:54:57 +0000 |
|---|---|---|
| committer | Brion Vibber <brion@pobox.com> | 2009-10-13 10:45:24 -0700 |
| commit | ed1ff81e948ca576ed439178c7d6482a09dc4140 (patch) | |
| tree | a3148a734f55c9532ad288463ab2411511bfe991 | |
| parent | 3727b17c39a9dba97b08f15211e3631c82162fdf (diff) | |
Include long-form attachment URL in notice if URL shortening is disabled.
Previously, the attachment URL would simply be dropped when shortening returned false instead of a short URL... the attachment was present if you clicked through to notice details but didn't appear in the timeline, making it nigh-impossible to see the attachment.
| -rw-r--r-- | actions/newnotice.php | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/actions/newnotice.php b/actions/newnotice.php index 00a822860..115cfd580 100644 --- a/actions/newnotice.php +++ b/actions/newnotice.php @@ -239,6 +239,10 @@ class NewnoticeAction extends Action $this->maybeAddRedir($fileRecord->id, $fileurl); $short_fileurl = common_shorten_url($fileurl); + if (!$short_fileurl) { + // todo -- Consider forcing default shortener if none selected? + $short_fileurl = $fileurl; + } $content_shortened .= ' ' . $short_fileurl; if (mb_strlen($content_shortened) > 140) { |