diff options
| author | Brion Vibber <brion@pobox.com> | 2010-05-11 12:16:13 -0700 |
|---|---|---|
| committer | Brion Vibber <brion@pobox.com> | 2010-05-11 12:16:13 -0700 |
| commit | 45392bef3382cd0bad30ebcd343d1cdd21e16f08 (patch) | |
| tree | 8d20e2543005850c66c681d3f59acb83f88f4375 | |
| parent | fba140f4e0246a244664f0c0fb2361b027508d35 (diff) | |
Installer tweak for Windows: normalize line endings to platform standard in generated config.php
Added a comment that the writable directory checks are insufficient to catch ACL problems on Windows; need a better check for that.
| -rw-r--r-- | lib/installer.php | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/lib/installer.php b/lib/installer.php index 589a19a66..58ffbfef7 100644 --- a/lib/installer.php +++ b/lib/installer.php @@ -128,6 +128,7 @@ abstract class Installer $pass = false; } + // @fixme this check seems to be insufficient with Windows ACLs if (!is_writable(INSTALLDIR)) { $this->warning(sprintf('Cannot write config file to: <code>%s</code></p>', INSTALLDIR), sprintf('On your server, try this command: <code>chmod a+w %s</code>', INSTALLDIR)); @@ -409,6 +410,10 @@ abstract class Installer "\$config['db']['database'] = '{$this->db['database']}';\n\n". ($this->db['type'] == 'pgsql' ? "\$config['db']['quote_identifiers'] = true;\n\n":''). "\$config['db']['type'] = '{$this->db['type']}';\n\n"; + + // Normalize line endings for Windows servers + $cfg = str_replace("\n", PHP_EOL, $cfg); + // write configuration file out to install directory $res = file_put_contents(INSTALLDIR.'/config.php', $cfg); |