Merge branch 'master' of /var/www/mublog

Conflicts:

	actions/api.php
	actions/deletenotice.php
	actions/recoverpassword.php
	actions/remotesubscribe.php
	actions/tag.php
	actions/tagrss.php
	actions/twitapiaccount.php
	actions/twitapiusers.php
	classes/Notice.php
	classes/User.php
	lib/common.php
	lib/language.php
	lib/subs.php
	lib/twitterapi.php
	lib/util.php
	scripts/inbox_users.php
	scripts/update_translations.php

Merged development trunk into laconica head. woohoo!

1 files changed, 86 insertions, 62 deletions

diff --git a/actions/disfavor.php b/actions/disfavor.php
index be208f65a..09b3bf18d 100644
--- a/actions/disfavor.php
+++ b/actions/disfavor.php
@@ -1,5 +1,17 @@
 <?php
-/*
+
+/**
+ * Disfavor action.
+ *
+ * PHP version 5
+ *
+ * @category Action
+ * @package  Laconica
+ * @author   Evan Prodromou <evan@controlyourself.ca>
+ * @author   Robin Millette <millette@controlyourself.ca>
+ * @license  http://www.fsf.org/licensing/licenses/agpl.html AGPLv3
+ * @link     http://laconi.ca/
+ *
  * Laconica - a distributed open-source microblogging tool
  * Copyright (C) 2008, Controlez-Vous, Inc.
  *
@@ -17,67 +29,79 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-if (!defined('LACONICA')) { exit(1); }
-
-class DisfavorAction extends Action {
-
-	function handle($args) {
-
-		parent::handle($args);
-
-		if (!common_logged_in()) {
-			common_user_error(_('Not logged in.'));
-			return;
-		}
-
-		$user = common_current_user();
-
-		if ($_SERVER['REQUEST_METHOD'] != 'POST') {
-			common_redirect(common_local_url('showfavorites', array('nickname' => $user->nickname)));
-			return;
-		}
-
-		$id = $this->trimmed('notice');
-
-		$notice = Notice::staticGet($id);
-
-		$token = $this->trimmed('token-'.$notice->id);
-
-		if (!$token || $token != common_session_token()) {
-			$this->client_error(_("There was a problem with your session token. Try again, please."));
-			return;
-		}
-
-		$fave = new Fave();
-		$fave->user_id = $this->id;
-		$fave->notice_id = $notice->id;
-		if (!$fave->find(true)) {
-			$this->client_error(_('This notice is not a favorite!'));
-			return;
-		}
-
-		$result = $fave->delete();
+if (!defined('LACONICA')) {
+    exit(1);
+}
 
-		if (!$result) {
-			common_log_db_error($fave, 'DELETE', __FILE__);
-			$this->server_error(_('Could not delete favorite.'));
-			return;
-		}
-		
-		$user->blowFavesCache();
+require_once INSTALLDIR.'/lib/favorform.php';
 
-		if ($this->boolean('ajax')) {
-			common_start_html('text/xml;charset=utf-8', true);
-			common_element_start('head');
-			common_element('title', null, _('Add to favorites'));
-			common_element_end('head');
-			common_element_start('body');
-			common_favor_form($notice);
-			common_element_end('body');
-			common_element_end('html');
-		} else {
-			common_redirect(common_local_url('showfavorites',
-											 array('nickname' => $user->nickname)));
-		}
-	}
+/**
+ * Disfavor class.
+ *
+ * @category Action
+ * @package  Laconica
+ * @author   Evan Prodromou <evan@controlyourself.ca>
+ * @author   Robin Millette <millette@controlyourself.ca>
+ * @license  http://www.fsf.org/licensing/licenses/agpl.html AGPLv3
+ * @link     http://laconi.ca/
+ */
+class DisfavorAction extends Action
+{
+    /**
+     * Class handler.
+     * 
+     * @param array $args query arguments
+     *
+     * @return void
+     */
+    function handle($args)
+    {
+        parent::handle($args);
+        if (!common_logged_in()) {
+            $this->clientError(_('Not logged in.'));
+            return;
+        }
+        $user = common_current_user();
+        if ($_SERVER['REQUEST_METHOD'] != 'POST') {
+            common_redirect(common_local_url('showfavorites',
+                array('nickname' => $user->nickname)));
+            return;
+        }
+        $id     = $this->trimmed('notice');
+        $notice = Notice::staticGet($id);
+        $token  = $this->trimmed('token-'.$notice->id);
+        if (!$token || $token != common_session_token()) {
+            $this->clientError(_("There was a problem with your session token. Try again, please."));
+            return;
+        }
+        $fave            = new Fave();
+        $fave->user_id   = $this->id;
+        $fave->notice_id = $notice->id;
+        if (!$fave->find(true)) {
+            $this->clientError(_('This notice is not a favorite!'));
+            return;
+        }
+        $result = $fave->delete();
+        if (!$result) {
+            common_log_db_error($fave, 'DELETE', __FILE__);
+            $this->serverError(_('Could not delete favorite.'));
+            return;
+        }
+        $user->blowFavesCache();
+        if ($this->boolean('ajax')) {
+            $this->startHTML('text/xml;charset=utf-8', true);
+            $this->elementStart('head');
+            $this->element('title', null, _('Add to favorites'));
+            $this->elementEnd('head');
+            $this->elementStart('body');
+            $favor = new FavorForm($this, $notice);
+            $favor->show();
+            $this->elementEnd('body');
+            $this->elementEnd('html');
+        } else {
+            common_redirect(common_local_url('showfavorites',
+                                             array('nickname' => $user->nickname)));
+        }
+    }
 }
+