Merge branch 'master' of /var/www/mublog

Conflicts:

	actions/api.php
	actions/deletenotice.php
	actions/recoverpassword.php
	actions/remotesubscribe.php
	actions/tag.php
	actions/tagrss.php
	actions/twitapiaccount.php
	actions/twitapiusers.php
	classes/Notice.php
	classes/User.php
	lib/common.php
	lib/language.php
	lib/subs.php
	lib/twitterapi.php
	lib/util.php
	scripts/inbox_users.php
	scripts/update_translations.php

Merged development trunk into laconica head. woohoo!

1 files changed, 105 insertions, 72 deletions

diff --git a/actions/favor.php b/actions/favor.php
index aede32902..8ecde4b11 100644
--- a/actions/favor.php
+++ b/actions/favor.php
@@ -1,4 +1,18 @@
 <?php
+
+/**
+ * Favor action.
+ *
+ * PHP version 5
+ *
+ * @category Action
+ * @package  Laconica
+ * @author   Evan Prodromou <evan@controlyourself.ca>
+ * @author   Robin Millette <millette@controlyourself.ca>
+ * @license  http://www.fsf.org/licensing/licenses/agpl.html AGPLv3
+ * @link     http://laconi.ca/
+ *
+
 /*
  * Laconica - a distributed open-source microblogging tool
  * Copyright (C) 2008, Controlez-Vous, Inc.
@@ -17,78 +31,97 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-if (!defined('LACONICA')) { exit(1); }
-
-require_once(INSTALLDIR.'/lib/mail.php');
-
-class FavorAction extends Action {
-
-	function handle($args) {
-		parent::handle($args);
-
-		if (!common_logged_in()) {
-			common_user_error(_('Not logged in.'));
-			return;
-		}
-
-		$user = common_current_user();
-
-		if ($_SERVER['REQUEST_METHOD'] != 'POST') {
-			common_redirect(common_local_url('showfavorites', array('nickname' => $user->nickname)));
-			return;
-		}
-
-		$id = $this->trimmed('notice');
-
-		$notice = Notice::staticGet($id);
-
-		# CSRF protection
-
-		$token = $this->trimmed('token-'.$notice->id);
-		if (!$token || $token != common_session_token()) {
-			$this->client_error(_("There was a problem with your session token. Try again, please."));
-			return;
-		}
-
-		if ($user->hasFave($notice)) {
-			$this->client_error(_('This notice is already a favorite!'));
-			return;
-		}
-
-		$fave = Fave::addNew($user, $notice);
-
-		if (!$fave) {
-			$this->server_error(_('Could not create favorite.'));
-			return;
-		}
-
-		$this->notify($fave, $notice, $user);
-		$user->blowFavesCache();
-		
-		if ($this->boolean('ajax')) {
-			common_start_html('text/xml;charset=utf-8', true);
-			common_element_start('head');
-			common_element('title', null, _('Disfavor favorite'));
-			common_element_end('head');
-			common_element_start('body');
-			common_disfavor_form($notice);
-			common_element_end('body');
-			common_element_end('html');
-		} else {
-			common_redirect(common_local_url('showfavorites',
-											 array('nickname' => $user->nickname)));
-		}
-	}
+if (!defined('LACONICA')) {
+    exit(1);
+}
 
-	function notify($fave, $notice, $user) {
-	    $other = User::staticGet('id', $notice->profile_id);
-		if ($other && $other->id != $user->id) {
-			if ($other->email && $other->emailnotifyfav) {
-				mail_notify_fave($other, $user, $notice);
-			}
-			# XXX: notify by IM
-			# XXX: notify by SMS
-		}
-	}
+require_once INSTALLDIR.'/lib/mail.php';
+require_once INSTALLDIR.'/lib/disfavorform.php';
 
+/**
+ * Favor class.
+ *
+ * @category Action
+ * @package  Laconica
+ * @author   Evan Prodromou <evan@controlyourself.ca>
+ * @author   Robin Millette <millette@controlyourself.ca>
+ * @license  http://www.fsf.org/licensing/licenses/agpl.html AGPLv3
+ * @link     http://laconi.ca/
+ */
+class FavorAction extends Action
+{
+    /**
+     * Class handler.
+     * 
+     * @param array $args query arguments
+     *
+     * @return void
+     */
+    function handle($args)
+    {
+        parent::handle($args);
+        if (!common_logged_in()) {
+            $this->clientError(_('Not logged in.'));
+            return;
+        }
+        $user = common_current_user();
+        if ($_SERVER['REQUEST_METHOD'] != 'POST') {
+            common_redirect(common_local_url('showfavorites',
+                array('nickname' => $user->nickname)));
+            return;
+        }
+        $id     = $this->trimmed('notice');
+        $notice = Notice::staticGet($id);
+        $token  = $this->trimmed('token-'.$notice->id);
+        if (!$token || $token != common_session_token()) {
+            $this->clientError(_("There was a problem with your session token. Try again, please."));
+            return;
+        }
+        if ($user->hasFave($notice)) {
+            $this->clientError(_('This notice is already a favorite!'));
+            return;
+        }
+        $fave = Fave::addNew($user, $notice);
+        if (!$fave) {
+            $this->serverError(_('Could not create favorite.'));
+            return;
+        }
+        $this->notify($notice, $user);
+        $user->blowFavesCache();
+        if ($this->boolean('ajax')) {
+            $this->startHTML('text/xml;charset=utf-8', true);
+            $this->elementStart('head');
+            $this->element('title', null, _('Disfavor favorite'));
+            $this->elementEnd('head');
+            $this->elementStart('body');
+            $disfavor = new DisFavorForm($this, $notice);
+            $disfavor->show();
+            $this->elementEnd('body');
+            $this->elementEnd('html');
+        } else {
+            common_redirect(common_local_url('showfavorites',
+                                             array('nickname' => $user->nickname)));
+        }
+    }
+
+    /**
+     * Notifies a user when his notice is favorited.
+     * 
+     * @param class $notice favorited notice
+     * @param class $user   user declaring a favorite
+     *
+     * @return void
+     */
+    function notify($notice, $user)
+    {
+        $other = User::staticGet('id', $notice->profile_id);
+        if ($other && $other->id != $user->id) {
+            if ($other->email && $other->emailnotifyfav) {
+                mail_notify_fave($other, $user, $notice);
+            }
+            // XXX: notify by IM
+            // XXX: notify by SMS
+        }
+    }
 }
+