use upper-case constants for roles and rights in hasRight()

1 files changed, 5 insertions, 3 deletions

diff --git a/classes/User.php b/classes/User.php
index 96a64ccb2..546406f71 100644
--- a/classes/User.php
+++ b/classes/User.php
@@ -705,10 +705,12 @@ class User extends Memcached_DataObject
         if (Event::handle('UserRightsCheck', array($this, $right, &$result))) {
             switch ($right)
             {
-             case Right::deleteOthersNotice:
-                $result = $this->hasRole('moderator');
+            case Right::DELETEOTHERSNOTICE:
+                $result = $this->hasRole(User_role::MODERATOR);
                 break;
-             default:
+            case Right::CONFIGURESITE:
+                $result = $this->hasRole(User_role::ADMINISTRATOR);
+            default:
                 $result = false;
                 break;
             }