From dd55916d5671f910698499f0786f9a94d95f5977 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Thu, 28 Aug 2008 22:51:27 -0400 Subject: CSRF protection in deletenotice darcs-hash:20080829025127-84dde-b3e2eb64b7dd8302037f471f6dba6949e2e15ecc.gz --- actions/deletenotice.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/actions/deletenotice.php b/actions/deletenotice.php index f2c040a5a..af620f036 100644 --- a/actions/deletenotice.php +++ b/actions/deletenotice.php @@ -49,6 +49,7 @@ class DeletenoticeAction extends DeleteAction { common_element_start('form', array('id' => 'notice_delete_form', 'method' => 'post', 'action' => common_local_url('deletenotice'))); + common_hidden('token', common_session_token()); common_hidden('notice', $this->trimmed('notice')); common_element_start('p'); common_element('span', array('id' => 'confirmation_text'), _('Are you sure you want to delete this notice?')); @@ -67,6 +68,12 @@ class DeletenoticeAction extends DeleteAction { } function delete_notice() { + # CSRF protection + $token = $this->trimmed('token'); + if (!$token || $token != common_session_token()) { + $this->show_form(_('There was a problem with your session token. Try again, please.')); + return; + } $url = common_get_returnto(); $confirmed = $this->trimmed('submit'); if ($confirmed == _('Yes')) { -- cgit v1.2.3-54-g00ecf