From d34fc127a55301a08560d4c2b45bdf057e852432 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Thu, 26 Jun 2008 17:46:54 -0400 Subject: better handling of too-long messages darcs-hash:20080626214654-34904-68a52888deaaca54fe39bcd77ae51997aa3a3959.gz --- actions/newnotice.php | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) (limited to 'actions') diff --git a/actions/newnotice.php b/actions/newnotice.php index 6d98c820c..64fe2494b 100644 --- a/actions/newnotice.php +++ b/actions/newnotice.php @@ -49,12 +49,12 @@ class NewnoticeAction extends Action { $this->show_form(_t('No content!')); return; } else if (strlen($notice->content) > 140) { - $this->show_form(_t('Notice content too long.')); + $this->show_form(_t('That\'s too long. Max notice size is 140 chars.')); return; } $id = $notice->insert(); - + if (!$id) { common_server_error(_t('Problem saving notice.')); return; @@ -62,12 +62,12 @@ class NewnoticeAction extends Action { $orig = clone($notice); $notice->uri = common_notice_uri($notice); - + if (!$notice->update($orig)) { common_server_error(_t('Problem saving notice.')); return; } - + common_broadcast_notice($notice); $returnto = $this->trimmed('returnto'); if ($returnto) { @@ -80,15 +80,17 @@ class NewnoticeAction extends Action { common_redirect($url, 303); } - function show_top($msg=NULL) { - if ($msg) { - common_element('div', 'error', $msg); - } + function show_top($content=NULL) { + common_notice_form(NULL, $content); } - + function show_form($msg=NULL) { - common_show_header(_t('New notice'), NULL, $msg, array($this, 'show_top')); - common_notice_form(); + $content = $this->trimmed('status_textarea'); + common_show_header(_t('New notice'), NULL, $content, + array($this, 'show_top')); + if ($msg) { + common_element('p', 'error', $msg); + } common_show_footer(); } } -- cgit v1.2.3-54-g00ecf