From c6d2e54a7159174736f0184b7b9bc8b7e08bb9df Mon Sep 17 00:00:00 2001 From: brion Date: Sat, 8 Aug 2009 17:54:57 -0700 Subject: Throttles updating of the character counter to reduce the performance impact on typing, especially on slower devices (mobiles, netbooks). http://laconi.ca/trac/ticket/1462 --- js/util.js | 36 ++++++++++++++++++++++++++++-------- 1 file changed, 28 insertions(+), 8 deletions(-) (limited to 'js/util.js') diff --git a/js/util.js b/js/util.js index 0ffa92ca9..440701937 100644 --- a/js/util.js +++ b/js/util.js @@ -17,21 +17,41 @@ */ $(document).ready(function(){ + var counterBlackout = false; + // count character on keyup function counter(event){ var maxLength = 140; var currentLength = $("#notice_data-text").val().length; var remaining = maxLength - currentLength; var counter = $("#notice_text-count"); - if (counter.text() != String(remaining)) { - counter.text(remaining); - } + + if (remaining.toString() != counter.text()) { + if (!counterBlackout || remaining == 0) { + if (counter.text() != String(remaining)) { + counter.text(remaining); + } - if (remaining < 0) { - $("#form_notice").addClass("warning"); - } else { - $("#form_notice").removeClass("warning"); - } + if (remaining < 0) { + $("#form_notice").addClass("warning"); + } else { + $("#form_notice").removeClass("warning"); + } + // Skip updates for the next 500ms. + // On slower hardware, updating on every keypress is unpleasant. + if (!counterBlackout) { + counterBlackout = true; + window.setTimeout(clearCounterBlackout, 500); + } + } + } + } + + function clearCounterBlackout() { + // Allow keyup events to poke the counter again + counterBlackout = false; + // Check if the string changed since we last looked + counter(null); } function submitonreturn(event) { -- cgit v1.2.3-54-g00ecf