From b7dd4d2ad1e93771cdff11198e7fdf81ca8633de Mon Sep 17 00:00:00 2001 From: sarven Date: Fri, 16 Jan 2009 23:13:22 +0000 Subject: Fix to put @class current on the navigation of the page viewed --- lib/action.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/action.php b/lib/action.php index 5ff536dab..fce9df4da 100644 --- a/lib/action.php +++ b/lib/action.php @@ -566,7 +566,7 @@ class Action extends HTMLOutputter // lawsuit $lattrs['class'] = 'current'; } - $this->elementStart('li', (is_null($id)) ? null : array('id' => $id), $lattrs); + $this->elementStart('li', (is_null($id)) ? $lattrs : array_merge(array('id' => $id), $lattrs)); $attrs['href'] = $url; if ($title) { $attrs['title'] = $title; -- cgit v1.2.3-54-g00ecf From 9881932d0734f515dc03e71551cfa7d04472f9a9 Mon Sep 17 00:00:00 2001 From: sarven Date: Fri, 16 Jan 2009 23:23:02 +0000 Subject: Minor --- lib/action.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/action.php b/lib/action.php index fce9df4da..1622047c0 100644 --- a/lib/action.php +++ b/lib/action.php @@ -565,8 +565,8 @@ class Action extends HTMLOutputter // lawsuit if ($is_selected) { $lattrs['class'] = 'current'; } - - $this->elementStart('li', (is_null($id)) ? $lattrs : array_merge(array('id' => $id), $lattrs)); + (is_null($id)) ? $lattrs : $lattrs['id'] = $id; + $this->elementStart('li', $lattrs); $attrs['href'] = $url; if ($title) { $attrs['title'] = $title; -- cgit v1.2.3-54-g00ecf From f46fd284e4395a113cdcc6e019d6f1b4b9ef8ff6 Mon Sep 17 00:00:00 2001 From: sarven Date: Fri, 16 Jan 2009 23:41:46 +0000 Subject: Update to forms and email settings --- actions/emailsettings.php | 50 +++++++++++++++++++++++++++++++++------------- lib/htmloutputter.php | 21 +++++-------------- lib/settingsgroupnav.php | 4 ++-- theme/base/css/display.css | 9 ++++++++- 4 files changed, 51 insertions(+), 33 deletions(-) (limited to 'lib') diff --git a/actions/emailsettings.php b/actions/emailsettings.php index 4cd63a9d3..d03d5ff84 100644 --- a/actions/emailsettings.php +++ b/actions/emailsettings.php @@ -85,42 +85,46 @@ class EmailsettingsAction extends SettingsAction $user = common_current_user(); $this->elementStart('form', array('method' => 'post', - 'id' => 'emailsettings', + 'id' => 'form_settings_email', + 'class' => 'form_settings', 'action' => common_local_url('emailsettings'))); - + $this->elementStart('fieldset'); + $this->element('legend', null, _('Email settings')); $this->hidden('token', common_session_token()); + $this->elementStart('div', array('id' => 'settings_email_address')); $this->element('h2', null, _('Address')); if ($user->email) { - $this->elementStart('p'); - $this->element('span', 'address confirmed', $user->email); - $this->element('span', 'input_instructions', - _('Current confirmed email address.')); + $this->element('p', array('id' => 'email_confirmed', $user->email)); + $this->element('p', array('class' => 'form_note'), _('Current confirmed email address.')); $this->hidden('email', $user->email); - $this->elementEnd('p'); $this->submit('remove', _('Remove')); } else { $confirm = $this->getConfirmation(); if ($confirm) { - $this->elementStart('p'); - $this->element('span', 'address unconfirmed', $confirm->address); - $this->element('span', 'input_instructions', - _('Awaiting confirmation on this address. '. - 'Check your inbox (and spam box!) for a message '. - 'with further instructions.')); + $this->element('p', array('id' => 'email_unconfirmed'), $confirm->address); + $this->element('p', array('class' => 'form_note'), + _('Awaiting confirmation on this address. '. + 'Check your inbox (and spam box!) for a message '. + 'with further instructions.')); $this->hidden('email', $confirm->address); - $this->elementEnd('p'); $this->submit('cancel', _('Cancel')); } else { + $this->elementStart('ul', 'form_datas'); + $this->elementStart('li'); $this->input('email', _('Email Address'), ($this->arg('email')) ? $this->arg('email') : null, _('Email address, like "UserName@example.org"')); + $this->elementEnd('li'); + $this->elementEnd('ul'); $this->submit('add', _('Add')); } } + $this->elementEnd('div'); + $this->elementStart('div', array('id' => 'settings_email_incoming')); if ($user->email) { $this->element('h2', null, _('Incoming email')); @@ -140,31 +144,49 @@ class EmailsettingsAction extends SettingsAction $this->elementEnd('p'); $this->submit('newincoming', _('New')); } + $this->elementEnd('div'); + $this->elementStart('div', array('id' => 'settings_email_preferences')); $this->element('h2', null, _('Preferences')); + $this->elementStart('ul', 'form_datas'); + $this->elementStart('li'); $this->checkbox('emailnotifysub', _('Send me notices of new subscriptions through email.'), $user->emailnotifysub); + $this->elementEnd('li'); + $this->elementStart('li'); $this->checkbox('emailnotifyfav', _('Send me email when someone '. 'adds my notice as a favorite.'), $user->emailnotifyfav); + $this->elementEnd('li'); + $this->elementStart('li'); $this->checkbox('emailnotifymsg', _('Send me email when someone sends me a private message.'), $user->emailnotifymsg); + $this->elementEnd('li'); + $this->elementStart('li'); $this->checkbox('emailnotifynudge', _('Allow friends to nudge me and send me an email.'), $user->emailnotifynudge); + $this->elementEnd('li'); + $this->elementStart('li'); $this->checkbox('emailpost', _('I want to post notices by email.'), $user->emailpost); + $this->elementEnd('li'); + $this->elementStart('li'); $this->checkbox('emailmicroid', _('Publish a MicroID for my email address.'), $user->emailmicroid); + $this->elementEnd('li'); + $this->elementEnd('ul'); + $this->elementEnd('div'); $this->submit('save', _('Save')); + $this->elementEnd('fieldset'); $this->elementEnd('form'); } diff --git a/lib/htmloutputter.php b/lib/htmloutputter.php index eb8a612e4..37853f345 100644 --- a/lib/htmloutputter.php +++ b/lib/htmloutputter.php @@ -155,20 +155,17 @@ class HTMLOutputter extends XMLOutputter function input($id, $label, $value=null, $instructions=null) { - $this->elementStart('p'); $this->element('label', array('for' => $id), $label); $attrs = array('name' => $id, 'type' => 'text', - 'class' => 'input_text', 'id' => $id); if ($value) { $attrs['value'] = htmlspecialchars($value); } $this->element('input', $attrs); if ($instructions) { - $this->element('span', 'input_instructions', $instructions); + $this->element('p', 'form_guide', $instructions); } - $this->elementEnd('p'); } /** @@ -192,7 +189,6 @@ class HTMLOutputter extends XMLOutputter function checkbox($id, $label, $checked=false, $instructions=null, $value='true', $disabled=false) { - $this->elementStart('p'); $attrs = array('name' => $id, 'type' => 'checkbox', 'class' => 'checkbox', @@ -213,9 +209,8 @@ class HTMLOutputter extends XMLOutputter $label); $this->text(' '); if ($instructions) { - $this->element('span', 'input_instructions', $instructions); + $this->element('p', 'form_guide', $instructions); } - $this->elementEnd('p'); } /** @@ -240,7 +235,6 @@ class HTMLOutputter extends XMLOutputter function dropdown($id, $label, $content, $instructions=null, $blank_select=false, $selected=null) { - $this->elementStart('p'); $this->element('label', array('for' => $id), $label); $this->elementStart('select', array('id' => $id, 'name' => $id)); if ($blank_select) { @@ -257,9 +251,8 @@ class HTMLOutputter extends XMLOutputter } $this->elementEnd('select'); if ($instructions) { - $this->element('span', 'input_instructions', $instructions); + $this->element('p', 'form_guide', $instructions); } - $this->elementEnd('p'); } /** @@ -296,7 +289,6 @@ class HTMLOutputter extends XMLOutputter function password($id, $label, $instructions=null) { - $this->elementStart('p'); $this->element('label', array('for' => $id), $label); $attrs = array('name' => $id, 'type' => 'password', @@ -304,9 +296,8 @@ class HTMLOutputter extends XMLOutputter 'id' => $id); $this->element('input', $attrs); if ($instructions) { - $this->element('span', 'input_instructions', $instructions); + $this->element('p', 'form_guide', $instructions); } - $this->elementEnd('p'); } /** @@ -348,7 +339,6 @@ class HTMLOutputter extends XMLOutputter function textarea($id, $label, $content=null, $instructions=null) { - $this->elementStart('p'); $this->element('label', array('for' => $id), $label); $this->element('textarea', array('rows' => 3, 'cols' => 40, @@ -356,8 +346,7 @@ class HTMLOutputter extends XMLOutputter 'id' => $id), ($content) ? $content : ''); if ($instructions) { - $this->element('span', 'input_instructions', $instructions); + $this->element('p', 'form_guide', $instructions); } - $this->elementEnd('p'); } } diff --git a/lib/settingsgroupnav.php b/lib/settingsgroupnav.php index 044c74552..bd66c65a6 100644 --- a/lib/settingsgroupnav.php +++ b/lib/settingsgroupnav.php @@ -94,7 +94,7 @@ class SettingsGroupNav extends Widget _('Other options'))); $action_name = $this->action->trimmed('action'); - $this->action->elementStart('ul', array('id' => 'nav_views')); + $this->action->elementStart('ul', array('class' => 'nav')); foreach ($menu as $menuaction => $menudesc) { if ($menuaction == 'imsettings' && @@ -104,7 +104,7 @@ class SettingsGroupNav extends Widget $this->action->menuItem(common_local_url($menuaction), $menudesc[0], $menudesc[1], - $action_name == $menuaction); + $action_name === $menuaction); } $this->action->elementEnd('ul'); diff --git a/theme/base/css/display.css b/theme/base/css/display.css index b8b260266..027cb1666 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -100,7 +100,7 @@ border:0; display:none; } .form_settings .form_datas label { -display:block; + } .form_guide { @@ -116,6 +116,13 @@ display:inline; font-weight:bold; } +.form_settings p { +margin-bottom:18px; +} + +#settings_email_address { +margin-bottom:29px; +} /* FORM SETTINGS */ -- cgit v1.2.3-54-g00ecf From 0a5125675b4165be4c8278edf8d30f33483081fa Mon Sep 17 00:00:00 2001 From: sarven Date: Sat, 17 Jan 2009 00:01:53 +0000 Subject: Updates to form styling --- actions/emailsettings.php | 28 ++++++++++++---------------- lib/htmloutputter.php | 2 +- theme/base/css/display.css | 13 ++++++++++++- 3 files changed, 25 insertions(+), 18 deletions(-) (limited to 'lib') diff --git a/actions/emailsettings.php b/actions/emailsettings.php index d03d5ff84..090df30dd 100644 --- a/actions/emailsettings.php +++ b/actions/emailsettings.php @@ -89,12 +89,10 @@ class EmailsettingsAction extends SettingsAction 'class' => 'form_settings', 'action' => common_local_url('emailsettings'))); - $this->elementStart('fieldset'); - $this->element('legend', null, _('Email settings')); - $this->hidden('token', common_session_token()); - $this->elementStart('div', array('id' => 'settings_email_address')); - $this->element('h2', null, _('Address')); + $this->elementStart('fieldset',array('id' => 'settings_email_address')); + $this->element('legend', null, _('Address')); + $this->hidden('token', common_session_token()); if ($user->email) { $this->element('p', array('id' => 'email_confirmed', $user->email)); @@ -122,12 +120,11 @@ class EmailsettingsAction extends SettingsAction $this->submit('add', _('Add')); } } - $this->elementEnd('div'); - - $this->elementStart('div', array('id' => 'settings_email_incoming')); - if ($user->email) { - $this->element('h2', null, _('Incoming email')); + $this->elementEnd('fieldset'); + if ($user->email) { + $this->elementStart('fieldset',array('id' => 'settings_email_incoming')); + $this->element('legend',_('Incoming email')); if ($user->incomingemail) { $this->elementStart('p'); $this->element('span', 'address', $user->incomingemail); @@ -143,11 +140,12 @@ class EmailsettingsAction extends SettingsAction 'cancels the old one.')); $this->elementEnd('p'); $this->submit('newincoming', _('New')); + $this->elementEnd('fieldset'); } - $this->elementEnd('div'); - $this->elementStart('div', array('id' => 'settings_email_preferences')); - $this->element('h2', null, _('Preferences')); + + $this->elementStart('fieldset', array('id' => 'settings_email_preferences')); + $this->element('legend', null, _('Preferences')); $this->elementStart('ul', 'form_datas'); $this->elementStart('li'); @@ -182,11 +180,9 @@ class EmailsettingsAction extends SettingsAction $user->emailmicroid); $this->elementEnd('li'); $this->elementEnd('ul'); - $this->elementEnd('div'); + $this->elementEnd('fieldset'); $this->submit('save', _('Save')); - - $this->elementEnd('fieldset'); $this->elementEnd('form'); } diff --git a/lib/htmloutputter.php b/lib/htmloutputter.php index 37853f345..71f17604b 100644 --- a/lib/htmloutputter.php +++ b/lib/htmloutputter.php @@ -204,7 +204,7 @@ class HTMLOutputter extends XMLOutputter } $this->element('input', $attrs); $this->text(' '); - $this->element('label', array('class' => 'checkbox_label', + $this->element('label', array('class' => 'checkbox', 'for' => $id), $label); $this->text(' '); diff --git a/theme/base/css/display.css b/theme/base/css/display.css index 027cb1666..294119c55 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -64,6 +64,13 @@ font-weight:bold; } form ul li input { } + +form input.checkbox { +position:relative; +top:2px; +left:0; +} + form .error { margin-right:11px; } @@ -97,7 +104,8 @@ padding:0; border:0; } .form_settings legend { -display:none; +font-size:1.6em; +text-transform:uppercase; } .form_settings .form_datas label { @@ -124,6 +132,9 @@ margin-bottom:18px; margin-bottom:29px; } +#settings_email_preferences label { +font-weight:normal; +} /* FORM SETTINGS */ -- cgit v1.2.3-54-g00ecf From b9fb70ee70ecd465f5843241b308f2b8680120f6 Mon Sep 17 00:00:00 2001 From: sarven Date: Sat, 17 Jan 2009 00:46:33 +0000 Subject: Markup clean up and styles --- actions/emailsettings.php | 7 +++---- actions/openidsettings.php | 15 ++++++++------- lib/action.php | 3 +-- theme/base/css/display.css | 4 ++++ 4 files changed, 16 insertions(+), 13 deletions(-) (limited to 'lib') diff --git a/actions/emailsettings.php b/actions/emailsettings.php index 090df30dd..355470815 100644 --- a/actions/emailsettings.php +++ b/actions/emailsettings.php @@ -90,7 +90,7 @@ class EmailsettingsAction extends SettingsAction 'action' => common_local_url('emailsettings'))); - $this->elementStart('fieldset',array('id' => 'settings_email_address')); + $this->elementStart('fieldset', array('id' => 'settings_email_address')); $this->element('legend', null, _('Address')); $this->hidden('token', common_session_token()); @@ -123,7 +123,7 @@ class EmailsettingsAction extends SettingsAction $this->elementEnd('fieldset'); if ($user->email) { - $this->elementStart('fieldset',array('id' => 'settings_email_incoming')); + $this->elementStart('fieldset', array('id' => 'settings_email_incoming')); $this->element('legend',_('Incoming email')); if ($user->incomingemail) { $this->elementStart('p'); @@ -180,9 +180,8 @@ class EmailsettingsAction extends SettingsAction $user->emailmicroid); $this->elementEnd('li'); $this->elementEnd('ul'); - $this->elementEnd('fieldset'); - $this->submit('save', _('Save')); + $this->elementEnd('fieldset'); $this->elementEnd('form'); } diff --git a/actions/openidsettings.php b/actions/openidsettings.php index f24c81795..6f17f154c 100644 --- a/actions/openidsettings.php +++ b/actions/openidsettings.php @@ -85,11 +85,11 @@ class OpenidsettingsAction extends SettingsAction $user = common_current_user(); $this->elementStart('form', array('method' => 'post', - 'id' => 'form_openid_add', + 'id' => 'form_settings_openid_add', 'class' => 'form_settings', 'action' => common_local_url('openidsettings'))); - $this->elementStart('fieldset'); + $this->elementStart('fieldset', array('id' => 'settings_openid_add')); $this->element('legend', null, _('Add OpenID')); $this->hidden('token', common_session_token()); $this->element('p', 'form_guide', @@ -105,7 +105,7 @@ class OpenidsettingsAction extends SettingsAction $this->elementEnd('li'); $this->elementEnd('ul'); $this->element('input', array('type' => 'submit', - 'id' => 'add', + 'id' => 'settings_openid_add_action-submit', 'name' => 'add', 'class' => 'submit', 'value' => _('Add'))); @@ -139,7 +139,7 @@ class OpenidsettingsAction extends SettingsAction } else { - $this->element('p', null, + $this->element('p', 'form_guide', _('You can remove an OpenID from your account '. 'by clicking the button marked "Remove".')); $idx = 0; @@ -147,10 +147,11 @@ class OpenidsettingsAction extends SettingsAction while ($oid->fetch()) { $this->elementStart('form', array('method' => 'POST', - 'id' => 'openiddelete' . $idx, + 'id' => 'form_settings_openid_delete' . $idx, + 'class' => 'form_settings', 'action' => common_local_url('openidsettings'))); - $this->elementStart('p'); + $this->elementStart('fieldset'); $this->hidden('token', common_session_token()); $this->element('a', array('href' => $oid->canonical), $oid->display); @@ -163,7 +164,7 @@ class OpenidsettingsAction extends SettingsAction 'name' => 'remove', 'class' => 'submit', 'value' => _('Remove'))); - $this->elementEnd('p'); + $this->elementEnd('fieldset'); $this->elementEnd('form'); $idx++; } diff --git a/lib/action.php b/lib/action.php index 1622047c0..35f6f2e3e 100644 --- a/lib/action.php +++ b/lib/action.php @@ -565,8 +565,7 @@ class Action extends HTMLOutputter // lawsuit if ($is_selected) { $lattrs['class'] = 'current'; } - (is_null($id)) ? $lattrs : $lattrs['id'] = $id; - $this->elementStart('li', $lattrs); + $this->elementStart('li', (is_null($id)) ? $lattrs : $lattr['id'] = $id); $attrs['href'] = $url; if ($title) { $attrs['title'] = $title; diff --git a/theme/base/css/display.css b/theme/base/css/display.css index 294119c55..3aee52088 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -99,6 +99,10 @@ form input.submit { /* FORM SETTINGS */ +.form_settings { +margin-bottom:29px; +} + .form_settings fieldset { padding:0; border:0; -- cgit v1.2.3-54-g00ecf From 607e65be81d6b42990706884f96fa024301c7893 Mon Sep 17 00:00:00 2001 From: sarven Date: Sat, 17 Jan 2009 02:32:13 +0000 Subject: Delete notice markup and styles --- lib/noticelist.php | 14 ++++++++------ theme/base/css/display.css | 17 +++++++++-------- theme/identica/css/display.css | 6 +++--- 3 files changed, 20 insertions(+), 17 deletions(-) (limited to 'lib') diff --git a/lib/noticelist.php b/lib/noticelist.php index fde93a3b6..1283e43e4 100644 --- a/lib/noticelist.php +++ b/lib/noticelist.php @@ -438,7 +438,7 @@ class NoticeListItem extends Widget $reply_url = common_local_url('newnotice', array('replyto' => $this->profile->nickname)); - $this->out->elementStart('dl', 'reply'); + $this->out->elementStart('dl', 'notice_reply'); $this->out->element('dt', null, _('Reply to this notice')); $this->out->elementStart('dd'); $this->out->element('a', array('href' => $reply_url, @@ -459,11 +459,13 @@ class NoticeListItem extends Widget if ($user && $this->notice->profile_id == $user->id) { $deleteurl = common_local_url('deletenotice', array('notice' => $this->notice->id)); - $this->out->elementStart('a', array('class' => 'deletenotice', - 'href' => $deleteurl, - 'title' => _('delete'))); - $this->out->raw(' ×'); - $this->out->elementEnd('a'); + $this->out->elementStart('dl', 'notice_delete'); + $this->out->element('dt', null, _('Delete this notice')); + $this->out->elementStart('dd'); + $this->out->element('a', array('href' => $deleteurl, + 'title' => _('delete')), _('Delete')); + $this->out->elementEnd('dd'); + $this->out->elementEnd('dl'); } } diff --git a/theme/base/css/display.css b/theme/base/css/display.css index fb7e71acd..20e66c351 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -775,25 +775,26 @@ outline:none; margin-left:2%; float:left; } -.notice-options .reply, +.notice-options .notice_reply, .notice-options .notice_delete , .notice-options .notice_favorite { float:left; margin-right:11px; } -.notice-options .reply { +.notice-options .notice_reply { margin-top:1px; } -.notice-options .reply dt { +.notice-options .notice_reply dt { display:none; } -.notice-options .reply a, +.notice-options .notice_reply a, .notice-options form input.submit { display:block; border:0; } -.notice-options .reply a { +.notice-options .notice_reply a, +.notice-options .notice_delete a { text-decoration:none; padding-left:20px; } @@ -802,7 +803,7 @@ cursor:pointer; padding:0 0 0 17px; } -.notice-options .notice_delete legend, +.notice-options .notice_delete dt, .notice-options .notice_favorite legend { display:none; } @@ -813,8 +814,8 @@ padding:0; } -.notice-options form.notice_delete { -margin-left:2em; +.notice-options .notice_delete { +margin-left:3em; } /*END: NOTICES */ diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css index aed4f95e5..94e97d414 100644 --- a/theme/identica/css/display.css +++ b/theme/identica/css/display.css @@ -173,17 +173,17 @@ background-image:url(../images/icons/twotone/green/flag.gif); background-image:url(../images/icons/twotone/green/document.gif); } -.notice-options .reply a, +.notice-options .notice_reply a, .notice-options form input.submit { background-color:transparent; } -.notice-options .reply a { +.notice-options .notice_reply a { background:transparent url(../images/icons/twotone/green/reply.gif) no-repeat 0 45%; } .notice-options form.notice_favorite input.submit { background:transparent url(../images/icons/twotone/green/favourite.gif) no-repeat 0 45%; } -.notice-options form.notice_delete input.submit { +.notice-options .notice_delete a { background:transparent url(../images/icons/twotone/green/trash.gif) no-repeat 0 45%; } -- cgit v1.2.3-54-g00ecf From 5a10287bc3e2ee2b2529bd95ce73d22e8c237e22 Mon Sep 17 00:00:00 2001 From: sarven Date: Sat, 17 Jan 2009 03:15:45 +0000 Subject: Minor --- lib/noticeform.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/noticeform.php b/lib/noticeform.php index 84817639a..d6a3aa9c2 100644 --- a/lib/noticeform.php +++ b/lib/noticeform.php @@ -144,8 +144,8 @@ class NoticeForm extends Form if ($this->action) { $this->out->hidden('notice_return-to', $this->action, 'returnto'); - $this->out->hidden('notice_in-reply-to', $this->action, 'inreplyto'); } + $this->out->hidden('notice_in-reply-to', $this->action, 'inreplyto'); } /** -- cgit v1.2.3-54-g00ecf From e7687c66b21fec1a2db524842505d229ce896e72 Mon Sep 17 00:00:00 2001 From: sarven Date: Sat, 17 Jan 2009 06:33:45 +0000 Subject: Using @id instead of @class for navigation li --- lib/action.php | 5 ++++- lib/personalgroupnav.php | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) (limited to 'lib') diff --git a/lib/action.php b/lib/action.php index 35f6f2e3e..71520b84e 100644 --- a/lib/action.php +++ b/lib/action.php @@ -565,7 +565,10 @@ class Action extends HTMLOutputter // lawsuit if ($is_selected) { $lattrs['class'] = 'current'; } - $this->elementStart('li', (is_null($id)) ? $lattrs : $lattr['id'] = $id); + + (is_null($id)) ? $lattrs : $lattrs['id'] = $id; + + $this->elementStart('li', $lattrs); $attrs['href'] = $url; if ($title) { $attrs['title'] = $title; diff --git a/lib/personalgroupnav.php b/lib/personalgroupnav.php index 5d727a505..63e6138df 100644 --- a/lib/personalgroupnav.php +++ b/lib/personalgroupnav.php @@ -91,28 +91,28 @@ class PersonalGroupNav extends Widget $user_profile = false; } - $this->out->elementStart('ul', array('id' => 'nav_views')); + $this->out->elementStart('ul', array('class' => 'nav')); $this->out->menuItem(common_local_url('all', array('nickname' => $nickname)), _('Personal'), sprintf(_('%s and friends'), (($user_profile && $user_profile->fullname) ? $user_profile->fullname : $nickname)), - $action == 'all'); + $action == 'all', 'nav_timeline_personal'); $this->out->menuItem(common_local_url('replies', array('nickname' => $nickname)), _('Replies'), sprintf(_('Replies to %s'), (($user_profile && $user_profile->fullname) ? $user_profile->fullname : $nickname)), - $action == 'replies'); + $action == 'replies', 'nav_timeline_replies'); $this->out->menuItem(common_local_url('showstream', array('nickname' => $nickname)), _('Profile'), ($user_profile && $user_profile->fullname) ? $user_profile->fullname : $nickname, - $action == 'showstream'); + $action == 'showstream', 'nav_profile'); $this->out->menuItem(common_local_url('showfavorites', array('nickname' => $nickname)), _('Favorites'), sprintf(_('%s\'s favorite notices'), ($user_profile) ? $user_profile->getBestName() : _('User')), - $action == 'showfavorites'); + $action == 'showfavorites', 'nav_timeline_favorites'); $cur = common_current_user(); -- cgit v1.2.3-54-g00ecf