summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrion Vibber <brion@pobox.com>2010-03-23 11:06:37 -0700
committerBrion Vibber <brion@pobox.com>2010-03-23 11:08:30 -0700
commit44caa3a93f452777c795006edb52ef4c5c2c4997 (patch)
tree633cd4537a35c6185c403b991ba132756bbba763
parent80b16c8499d0cfdb4deb442ba18345befed4e29d (diff)
Consistently send Profiles into Fave::addNew()
-rw-r--r--actions/apifavoritecreate.php2
-rw-r--r--classes/Fave.php10
-rw-r--r--lib/command.php2
3 files changed, 11 insertions, 3 deletions
diff --git a/actions/apifavoritecreate.php b/actions/apifavoritecreate.php
index 3618f9401..00b6349b0 100644
--- a/actions/apifavoritecreate.php
+++ b/actions/apifavoritecreate.php
@@ -123,7 +123,7 @@ class ApiFavoriteCreateAction extends ApiAuthAction
return;
}
- $fave = Fave::addNew($this->user, $this->notice);
+ $fave = Fave::addNew($this->user->getProfile(), $this->notice);
if (empty($fave)) {
$this->clientError(
diff --git a/classes/Fave.php b/classes/Fave.php
index a04f15e9c..7ca9ade7f 100644
--- a/classes/Fave.php
+++ b/classes/Fave.php
@@ -21,7 +21,15 @@ class Fave extends Memcached_DataObject
/* the code above is auto generated do not remove the tag below */
###END_AUTOCODE
- static function addNew($profile, $notice) {
+ /**
+ * Save a favorite record.
+ * @fixme post-author notification should be moved here
+ *
+ * @param Profile $profile the local or remote user who likes
+ * @param Notice $notice the notice that is liked
+ * @return mixed false on failure, or Fave record on success
+ */
+ static function addNew(Profile $profile, Notice $notice) {
$fave = null;
diff --git a/lib/command.php b/lib/command.php
index 9d550550f..8080fb8bc 100644
--- a/lib/command.php
+++ b/lib/command.php
@@ -273,7 +273,7 @@ class FavCommand extends Command
function handle($channel)
{
$notice = $this->getNotice($this->other);
- $fave = Fave::addNew($this->user, $notice);
+ $fave = Fave::addNew($this->user->getProfile(), $notice);
if (!$fave) {
$channel->error($this->user, _('Could not create favorite.'));