summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZach Copley <zach@status.net>2010-05-25 15:40:38 +0000
committerZach Copley <zach@status.net>2010-05-25 15:40:38 +0000
commit09dab2ce5ae819c73d7984822d418c43f1fba223 (patch)
tree42db8c7f70ef61148cfdf92c173cad39d206198e
parent9cde924bb3f928d9df0519a9a6b995633eb45789 (diff)
Dequeue notice when we hit any Facebook error.
-rw-r--r--plugins/Facebook/facebookutil.php7
1 files changed, 3 insertions, 4 deletions
diff --git a/plugins/Facebook/facebookutil.php b/plugins/Facebook/facebookutil.php
index 0f24f5441..c7b0f02c3 100644
--- a/plugins/Facebook/facebookutil.php
+++ b/plugins/Facebook/facebookutil.php
@@ -229,8 +229,8 @@ function handleFacebookError($e, $notice, $flink)
default:
$msg = "FacebookPlugin - Facebook returned an error we don't know how to deal with while trying to "
. "post notice %d. Error code: %d, error message: \"%s\". (Notice details: "
- . "nickname=%s, user ID=%d, Facebook ID=%d, notice content=\"%s\"). Re-queueing "
- . "notice, and will try to send again later.";
+ . "nickname=%s, user ID=%d, Facebook ID=%d, notice content=\"%s\"). Removing notice "
+ . "from the Facebook queue for safety.";
common_log(
LOG_ERR, sprintf(
$msg,
@@ -243,8 +243,7 @@ function handleFacebookError($e, $notice, $flink)
$notice->content
)
);
- // Re-queue and try again later
- return false;
+ return true; // dequeue
break;
}
}