Merge branch 'master' of /var/www/mublog

Conflicts:

	actions/api.php
	actions/deletenotice.php
	actions/recoverpassword.php
	actions/remotesubscribe.php
	actions/tag.php
	actions/tagrss.php
	actions/twitapiaccount.php
	actions/twitapiusers.php
	classes/Notice.php
	classes/User.php
	lib/common.php
	lib/language.php
	lib/subs.php
	lib/twitterapi.php
	lib/util.php
	scripts/inbox_users.php
	scripts/update_translations.php

Merged development trunk into laconica head. woohoo!

1 files changed, 62 insertions, 59 deletions

diff --git a/actions/postnotice.php b/actions/postnotice.php
index 243081f12..0b4735296 100644
--- a/actions/postnotice.php
+++ b/actions/postnotice.php
@@ -21,68 +21,71 @@ if (!defined('LACONICA')) { exit(1); }
 
 require_once(INSTALLDIR.'/lib/omb.php');
 
-class PostnoticeAction extends Action {
-	function handle($args) {
-		parent::handle($args);
-		try {
-			common_remove_magic_from_request();
-			$req = OAuthRequest::from_request();
-			# Note: server-to-server function!
-			$server = omb_oauth_server();
-			list($consumer, $token) = $server->verify_request($req);
-			if ($this->save_notice($req, $consumer, $token)) {
-				print "omb_version=".OMB_VERSION_01;
-			}
-		} catch (OAuthException $e) {
-			common_server_error($e->getMessage());
-			return;
-		}
-	}
+class PostnoticeAction extends Action
+{
+    function handle($args)
+    {
+        parent::handle($args);
+        try {
+            common_remove_magic_from_request();
+            $req = OAuthRequest::from_request();
+            # Note: server-to-server function!
+            $server = omb_oauth_server();
+            list($consumer, $token) = $server->verify_request($req);
+            if ($this->save_notice($req, $consumer, $token)) {
+                print "omb_version=".OMB_VERSION_01;
+            }
+        } catch (OAuthException $e) {
+            $this->serverError($e->getMessage());
+            return;
+        }
+    }
 
-	function save_notice(&$req, &$consumer, &$token) {
-		$version = $req->get_parameter('omb_version');
-		if ($version != OMB_VERSION_01) {
-			common_user_error(_('Unsupported OMB version'), 400);
-			return false;
-		}
-		# First, check to see
-		$listenee =  $req->get_parameter('omb_listenee');
-		$remote_profile = Remote_profile::staticGet('uri', $listenee);
-		if (!$remote_profile) {
-			common_user_error(_('Profile unknown'), 403);
-			return false;
-		}
-		$sub = Subscription::staticGet('token', $token->key);
-		if (!$sub) {
-			common_user_error(_('No such subscription'), 403);
-			return false;
-		}
-		$content = $req->get_parameter('omb_notice_content');
+    function save_notice(&$req, &$consumer, &$token)
+    {
+        $version = $req->get_parameter('omb_version');
+        if ($version != OMB_VERSION_01) {
+            $this->clientError(_('Unsupported OMB version'), 400);
+            return false;
+        }
+        # First, check to see
+        $listenee =  $req->get_parameter('omb_listenee');
+        $remote_profile = Remote_profile::staticGet('uri', $listenee);
+        if (!$remote_profile) {
+            $this->clientError(_('Profile unknown'), 403);
+            return false;
+        }
+        $sub = Subscription::staticGet('token', $token->key);
+        if (!$sub) {
+            $this->clientError(_('No such subscription'), 403);
+            return false;
+        }
+        $content = $req->get_parameter('omb_notice_content');
         $content_shortened = common_shorten_links($content);
         if (mb_strlen($content_shortened) > 140) {
-            common_user_error(_('Invalid notice content'), 400);
+            $this->clientError(_('Invalid notice content'), 400);
+            return false;
+        }
+        $notice_uri = $req->get_parameter('omb_notice');
+        if (!Validate::uri($notice_uri) &&
+            !common_valid_tag($notice_uri)) {
+            $this->clientError(_('Invalid notice uri'), 400);
             return false;
         }
-		$notice_uri = $req->get_parameter('omb_notice');
-		if (!Validate::uri($notice_uri) &&
-			!common_valid_tag($notice_uri)) {
-			common_user_error(_('Invalid notice uri'), 400);
-			return false;
-		}
-		$notice_url = $req->get_parameter('omb_notice_url');
-		if ($notice_url && !common_valid_http_url($notice_url)) {
-			common_user_error(_('Invalid notice url'), 400);
-			return false;
-		}
-		$notice = Notice::staticGet('uri', $notice_uri);
-		if (!$notice) {
-			$notice = Notice::saveNew($remote_profile->id, $content, 'omb', false, 0, $notice_uri);
-			if (is_string($notice)) {
-				common_server_serror($notice, 500);
-				return false;
-			}
-			common_broadcast_notice($notice, true);
-		}
-		return true;
-	}
+        $notice_url = $req->get_parameter('omb_notice_url');
+        if ($notice_url && !common_valid_http_url($notice_url)) {
+            $this->clientError(_('Invalid notice url'), 400);
+            return false;
+        }
+        $notice = Notice::staticGet('uri', $notice_uri);
+        if (!$notice) {
+            $notice = Notice::saveNew($remote_profile->id, $content, 'omb', false, 0, $notice_uri);
+            if (is_string($notice)) {
+                common_server_serror($notice, 500);
+                return false;
+            }
+            common_broadcast_notice($notice, true);
+        }
+        return true;
+    }
 }