diff options
author | Brion Vibber <brion@pobox.com> | 2010-12-17 16:08:37 -0800 |
---|---|---|
committer | Brion Vibber <brion@pobox.com> | 2010-12-17 16:08:37 -0800 |
commit | fb65d5901d586a13886b81d84de8959b67b6aa9e (patch) | |
tree | 00cb879e21f055479f997ead9bd2c99404655af7 /classes/Notice.php | |
parent | 71151b3bc0e1b1d4d560bf296eb0a572485389e8 (diff) |
Update sorting for conversation views: adds notice_conversation_created_id_idx index on notice, replacing more limited notice_conversation_idx
Diffstat (limited to 'classes/Notice.php')
-rw-r--r-- | classes/Notice.php | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/classes/Notice.php b/classes/Notice.php index ea69a5bed..629b7089d 100644 --- a/classes/Notice.php +++ b/classes/Notice.php @@ -704,19 +704,14 @@ class Notice extends Memcached_DataObject $notice->conversation = $id; - $notice->orderBy('id DESC'); + $notice->orderBy('created DESC, id DESC'); if (!is_null($offset)) { $notice->limit($offset, $limit); } - if ($since_id != 0) { - $notice->whereAdd('id > ' . $since_id); - } - - if ($max_id != 0) { - $notice->whereAdd('id <= ' . $max_id); - } + Notice::addWhereSinceId($notice, $since_id); + Notice::addWhereMaxId($notice, $max_id); $ids = array(); |