diff options
author | Brion Vibber <brion@pobox.com> | 2010-03-11 11:01:01 -0800 |
---|---|---|
committer | Brion Vibber <brion@pobox.com> | 2010-03-11 11:01:01 -0800 |
commit | ce92bc71431ec878c391b1ac6e16fd59cafd50b1 (patch) | |
tree | f1f3ee9404cab29c578a6c11baff08d20d60c8e7 /classes/Profile.php | |
parent | 66518df4356ea878bfd8693191f0354caebfb549 (diff) |
Drop timestamp cutoff parameter from User::getCurrentNotice() and Profile::getCurrentNotice().
It's not currently used, and won't be efficient when we update the notice.profile_id_idx index to optimize for our id-based sorting when pulling user post lists for profile pages, feeds etc.
Diffstat (limited to 'classes/Profile.php')
-rw-r--r-- | classes/Profile.php | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/classes/Profile.php b/classes/Profile.php index 0322c9358..91f6e4692 100644 --- a/classes/Profile.php +++ b/classes/Profile.php @@ -147,14 +147,16 @@ class Profile extends Memcached_DataObject return ($this->fullname) ? $this->fullname : $this->nickname; } - # Get latest notice on or before date; default now - function getCurrentNotice($dt=null) + /** + * Get the most recent notice posted by this user, if any. + * + * @return mixed Notice or null + */ + function getCurrentNotice() { $notice = new Notice(); $notice->profile_id = $this->id; - if ($dt) { - $notice->whereAdd('created < "' . $dt . '"'); - } + // @fixme change this to sort on notice.id only when indexes are updated $notice->orderBy('created DESC, notice.id DESC'); $notice->limit(1); if ($notice->find(true)) { |