diff options
author | Brion Vibber <brion@status.net> | 2010-09-07 16:15:32 -0700 |
---|---|---|
committer | Brion Vibber <brion@status.net> | 2010-09-07 16:22:51 -0700 |
commit | d470c007fc18c9112804155e495ff295cd60ef88 (patch) | |
tree | a04c5f156b04b90b4c43f91e83b84d3e6a6bdf28 /classes | |
parent | 6786bbcfbfb445b190fd03e602ee0b1a85abb2af (diff) |
Quick fix for #2659: unable to login with Livejournal OpenID
The Net::OpenID::Server perl module that LJ uses appears to be very picky about input, and rejects most request types unless the data comes in as GET parameters (apparently following OpenID 1.1 rules, rather than OpenID 2.0 rules which permit any request to be POSTed but requires that if so, the data must all be in the POST body).
Apparently something got updated on LJ at some point that's either added that behavior or (more likely) added the OpenID 2.0 namespace info to discovery, which tells the Janrain-based OpenID libraries that they should go ahead and do POST requests instead of redirects to GET requests... thus breaking everything. ;)
GET should be just fine for both 1.1 and 2.0 though, and also saves having to sit through that lame autosubmit page.
Switched the authentication submission from checking whether it should redirect to GET or do a form POST, to simply always doing the redirect to GET.
Tested against providers:
* LiveJournal
* Google
* LaunchPad
* identi.ca
Diffstat (limited to 'classes')
0 files changed, 0 insertions, 0 deletions