Convert Notice::asAtomEntry() to use Notice::asActivity() and Activity::asString()

We had two ways to generate an activity entry from a notice; one through
Notice::asAtomEntry() and one through Notice::asActivity() and
Activity::asString(). The code paths had already diverged somewhat. I
took the conditions that were in Notice::asAtomEntry() and made sure
they were replicated in the other two functions. Then, I rewrote
Notice::asAtomEntry() to use the other two functions instead.

This change passes the ActivityGenerationTests unit tests, but there
may be some other stuff that's not getting covered.

1 files changed, 1 insertions, 1 deletions

diff --git a/lib/atomcategory.php b/lib/atomcategory.php
index 4cc3b4f4d..9763023f7 100644
--- a/lib/atomcategory.php
+++ b/lib/atomcategory.php
@@ -72,6 +72,6 @@ class AtomCategory
         }
         $xs = new XMLStringer();
         $xs->element('category', $attribs);
-        return $xs->asString();
+        return $xs->getString();
     }
 }