summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorEvan Prodromou <evan@controlyourself.ca>2009-04-01 15:30:59 -0400
committerEvan Prodromou <evan@controlyourself.ca>2009-04-01 15:30:59 -0400
commitc172cbafaa9ba17ff8ca5c6dd07741bd0de96871 (patch)
treebc4d14b74e195e2f22e5e59d82d9ac95308a8e43 /lib
parent88bcef127ffb5b906f4196977b64cd096126b946 (diff)
Try to do intelligent redirect codes
After fixing the redirect code output, there are a lot of weirdnesses with e.g. form handling. Try to add explicit redirect codes where needed -- principly when handling a POST.
Diffstat (limited to 'lib')
-rw-r--r--lib/openid.php2
-rw-r--r--lib/settingsaction.php4
2 files changed, 3 insertions, 3 deletions
diff --git a/lib/openid.php b/lib/openid.php
index f3769c6fc..3af7a39cf 100644
--- a/lib/openid.php
+++ b/lib/openid.php
@@ -171,7 +171,7 @@ function oid_authenticate($openid_url, $returnto, $immediate=false)
} else if (Auth_OpenID::isFailure($redirect_url)) {
return sprintf(_('Could not redirect to server: %s'), $redirect_url->message);
} else {
- common_redirect($redirect_url);
+ common_redirect($redirect_url, 303);
}
} else {
// Generate form markup and render it.
diff --git a/lib/settingsaction.php b/lib/settingsaction.php
index 53c807c6f..db20c5804 100644
--- a/lib/settingsaction.php
+++ b/lib/settingsaction.php
@@ -78,9 +78,9 @@ class SettingsAction extends Action
common_set_returnto($this->selfUrl());
$user = common_current_user();
if ($user->hasOpenID()) {
- common_redirect(common_local_url('openidlogin'));
+ common_redirect(common_local_url('openidlogin'), 303);
} else {
- common_redirect(common_local_url('login'));
+ common_redirect(common_local_url('login'), 303);
}
} else if ($_SERVER['REQUEST_METHOD'] == 'POST') {
$this->handlePost();