summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorBrion Vibber <brion@pobox.com>2010-03-02 11:54:02 -0800
committerBrion Vibber <brion@pobox.com>2010-03-02 11:54:02 -0800
commit6b134ae4c7e15ce9853bc82545c3beb67a2dfdad (patch)
treec28f2857d42b6bc97f602fe4c3458a5dd2ca9bc2 /lib
parentf596e072e79ec87541b27008ea2327275e5fc669 (diff)
Dropped deprecated timestamp-based 'since' parameter for all API methods. When it sneaks in it can cause some very slow queries due to mismatches with the indexing.
Twitter removed 'since' support some time ago, and we've already removed it from the public timeline, so it shouldn't be missed.
Diffstat (limited to 'lib')
-rw-r--r--lib/apiaction.php8
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/apiaction.php b/lib/apiaction.php
index 2af150ab9..8049c0901 100644
--- a/lib/apiaction.php
+++ b/lib/apiaction.php
@@ -63,7 +63,6 @@ class ApiAction extends Action
var $count = null;
var $max_id = null;
var $since_id = null;
- var $since = null;
var $access = self::READ_ONLY; // read (default) or read-write
@@ -85,7 +84,10 @@ class ApiAction extends Action
$this->count = (int)$this->arg('count', 20);
$this->max_id = (int)$this->arg('max_id', 0);
$this->since_id = (int)$this->arg('since_id', 0);
- $this->since = $this->arg('since');
+
+ if ($this->arg('since')) {
+ $this->clientError(_("since parameter is disabled for performance; use since_id"), 403);
+ }
return true;
}
@@ -1325,8 +1327,6 @@ class ApiAction extends Action
case 'max_id':
$max_id = (int)$this->args['max_id'];
return ($max_id < 1) ? 0 : $max_id;
- case 'since':
- return strtotime($this->args['since']);
default:
return parent::arg($key, $def);
}