From 593d41f78b8caa94208abdd5787ef26280460b61 Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Wed, 4 Feb 2009 16:45:46 +0000 Subject: Using overflow:hidden for long strings that don't contain any whitespace. This is both a preventive measure for user content that is abused (i.e., leaking text into other page components) and for aesthetics (requested by @evan) --- theme/base/css/display.css | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/theme/base/css/display.css b/theme/base/css/display.css index e2a2a965c..638b09520 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -24,6 +24,7 @@ position:relative; h1,h2,h3,h4,h5,h6 { text-transform:uppercase; margin-bottom:7px; +overflow:hidden; } h1 { font-size:1.4em; @@ -508,6 +509,7 @@ min-height:123px; float:left; margin-bottom:18px; margin-left:0; +overflow:hidden; } .entity_profile dt, #entity_statistics dt { @@ -767,6 +769,10 @@ padding-left:28px; margin-right:11px; } +.fn { +overflow:hidden; +} + .notice .author .fn { font-weight:bold; } @@ -791,7 +797,7 @@ text-decoration:underline; .notice .entry-title { float:left; width:100%; -overflow:auto; +overflow:hidden; } #shownotice .notice .entry-title { font-size:2.2em; -- cgit v1.2.3-54-g00ecf From b8e10428d3f5e86cab97e226947f077ba98f907e Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Wed, 4 Feb 2009 17:03:59 +0000 Subject: Changed error and facebookaction wrap selector from @class to @id. --- lib/error.php | 2 +- lib/facebookaction.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/error.php b/lib/error.php index 03065bc70..526d9f81b 100644 --- a/lib/error.php +++ b/lib/error.php @@ -111,7 +111,7 @@ class ErrorAction extends Action function showBody() { $this->elementStart('body', array('id' => 'error')); - $this->elementStart('div', 'wrap'); + $this->elementStart('div', array('id' => 'wrap')); $this->showHeader(); $this->showCore(); $this->showFooter(); diff --git a/lib/facebookaction.php b/lib/facebookaction.php index bfba702e6..f42427540 100644 --- a/lib/facebookaction.php +++ b/lib/facebookaction.php @@ -168,7 +168,7 @@ class FacebookAction extends Action function showBody() { - $this->elementStart('div', 'wrap'); + $this->elementStart('div', array('id' => 'wrap')); $this->showHeader(); $this->showCore(); $this->showFooter(); -- cgit v1.2.3-54-g00ecf From b43bdda312fb10501597251f406e58b5b907d480 Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Wed, 4 Feb 2009 18:18:25 +0000 Subject: Removing extra margin after .section .notice .author. --- theme/base/css/display.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/theme/base/css/display.css b/theme/base/css/display.css index 638b09520..60eaa8f22 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -1078,6 +1078,10 @@ border-top:0; .section .notice:first-child { padding-top:0; } + +.section .notice .author { +margin-right:0; +} .section .notice .author .fn { display:none; } -- cgit v1.2.3-54-g00ecf From df41b1307f9a2690115e246e584d6a398d4f9730 Mon Sep 17 00:00:00 2001 From: Zach Copley Date: Wed, 4 Feb 2009 11:55:22 -0800 Subject: Removed erroneous comments referring to old common_notice_form() func --- actions/login.php | 1 - actions/newnotice.php | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/actions/login.php b/actions/login.php index 11cf1f02a..6c6567b7b 100644 --- a/actions/login.php +++ b/actions/login.php @@ -96,7 +96,6 @@ class LoginAction extends Action { // XXX: login throttle - // CSRF protection - token set in common_notice_form() $token = $this->trimmed('token'); if (!$token || $token != common_session_token()) { $this->clientError(_('There was a problem with your session token. '. diff --git a/actions/newnotice.php b/actions/newnotice.php index 61f0f8365..5e7691f33 100644 --- a/actions/newnotice.php +++ b/actions/newnotice.php @@ -90,7 +90,7 @@ class NewnoticeAction extends Action $this->clientError(_('Not logged in.')); } else if ($_SERVER['REQUEST_METHOD'] == 'POST') { - // CSRF protection - token set in common_notice_form() + // CSRF protection $token = $this->trimmed('token'); if (!$token || $token != common_session_token()) { $this->clientError(_('There was a problem with your session token. '. -- cgit v1.2.3-54-g00ecf