From b994d529f4de53df6350e12b5e81889cee17f317 Mon Sep 17 00:00:00 2001
From: Zach Copley <zach@status.net>
Date: Mon, 15 Mar 2010 19:06:06 -0700
Subject: Throw an exception if we receive a document instead of a feed's root
 element

---
 lib/activity.php | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

(limited to 'lib/activity.php')

diff --git a/lib/activity.php b/lib/activity.php
index ae65fe36f..d84eabf7c 100644
--- a/lib/activity.php
+++ b/lib/activity.php
@@ -1083,15 +1083,11 @@ class Activity
 
         $this->entry = $entry;
 
-        // @fixme Don't send in a DOMDocument
+        // Insist on a feed's root DOMElement; don't allow a DOMDocument
         if ($feed instanceof DOMDocument) {
-            common_log(
-                LOG_WARNING,
-                'Activity::__construct() - '
-                . 'DOMDocument passed in for feed by mistake. '
-                . "Expecting a 'feed' DOMElement."
+            throw new ClientException(
+                _("Expecting a root feed element but got a whole XML document.")
             );
-            $feed = $feed->getElementsByTagName('feed')->item(0);
         }
 
         $this->feed  = $feed;
-- 
cgit v1.2.3-54-g00ecf