Add tests for librechroot's help system, make them pass.

They didn't pass because on several errors it printed to stdout, not stderr

1 files changed, 40 insertions, 0 deletions

diff --git a/test/librechroot-test.sh b/test/librechroot-test.sh
index d8f7299..c9fa130 100644
--- a/test/librechroot-test.sh
+++ b/test/librechroot-test.sh
@@ -6,6 +6,7 @@ before() {
 	tmpdir=$(mktemp -d --tmpdir test-librechroot.XXXXXXXXXXXX)
 	mkdir -p "$XDG_CONFIG_HOME"/libretools
 	echo "CHROOTDIR='$tmpdir'" > "$XDG_CONFIG_HOME"/libretools/chroot.conf
+	stat=0
 }
 
 after() {
@@ -15,3 +16,42 @@ after() {
 it_creates_repo_for_new_chroots() {
 	sudo librechroot run test -r /repo/repo.db
 }
+
+it_displays_help_as_normal_user() {
+	librechroot help >$tmpdir/stdout 2>$tmpdir/stderr
+
+	[[ "$(sed 1q $tmpdir/stdout)" =~ Usage:.* ]]
+	[[ -z "$(cat $tmpdir/stderr)" ]]
+}
+
+it_otherwise_fails_as_normal_user() {
+	librechroot run true >$tmpdir/stdout 2>$tmpdir/stderr || stat=$?
+
+	[[ $stat != 0 ]]
+	[[ -z "$(cat $tmpdir/stdout)" ]]
+	[[ -n "$(cat $tmpdir/stderr)" ]]
+}
+
+it_displays_help_and_fails_with_0_args() {
+	librechroot >$tmpdir/stdout 2>$tmpdir/stderr || stat=$?
+
+	[[ $stat != 0 ]]
+	[[ -z "$(cat $tmpdir/stdout)" ]]
+	[[ "$(sed 1q $tmpdir/stderr)" =~ Usage:.* ]]
+}
+
+it_fails_for_unknown_commands() {
+	sudo librechroot phony >$tmpdir/stdout 2>$tmpdir/stderr || stat=$?
+
+	[[ $stat != 0 ]]
+	[[ -z "$(cat $tmpdir/stdout)" ]]
+	[[ -n "$(cat $tmpdir/stderr)" ]]
+}
+
+it_fails_for_unknown_flags() {
+	sudo librechroot -q >$tmpdir/stdout 2>$tmpdir/stderr || stat=$?
+
+	[[ $stat != 0 ]]
+	[[ -z "$(cat $tmpdir/stdout)" ]]
+	[[ -n "$(cat $tmpdir/stderr)" ]]
+}