Age | Commit message (Collapse) | Author |
|
This allows access to the same data (and even a bit more) from the
signoffs overview page in a machine-friendly way.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This improves the shitty query plan brought upon us by MySQL by
rewriting it to use JOINs only and no dependent subqueries.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Don't send the email at all if there are no packages even in the
repository, and don't print empty sections.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
And add a count of displayed rows below the filter options.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
I clearly should not have removed this code yesterday, otherwise
packages have their target repo matched to a testing one.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This should save a significant amount of time in the case where there
are a lot of signups to look up; at least one query per signoff row.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This is rather sick to look at. Sorry, Django gives me no other choice.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This allows us to alleviate the N+1 query problem when we want
maintainer data for a queryset of packages. We use it on signoffs here;
we should also be able to apply this to the todolist section where this
problem has existed for some time.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This is a more expensive and not-yet-optimized way of doing this, but we
can fix that later as needed.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
If you check the new box, you can set the options for both the i686 and
the x86_64 packages at the same time.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
* Better signoff report with more detail
* Show signoff specification in signoffs view
* Honor disabled/bad flags and display in approval column
* Various other small bugfixes and tweaks
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This allows the criteria and other information about certain signoffs to
be overridden as necessary.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This sets up some shared utility code for use in a later package signoff
email report command.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Add a new 'SignoffSpecification' model which will capture metadata
regarding a specific package if it differs from the norm- e.g. more or
less than 2 required signoffs, is known to be bad, a comment from the
maintainer, etc. The groundwork is laid here; much of this will still
need to be wired up in the future.
Enhance the view with a lot more JS prettiness and add revoking of
signoffs. The signoff page can be filtered and the links and all the fun
stuff are totally dynamic now.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
I'm stupid and didn't realize it was referenced before the location I
moved it to.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Move initializations closer to where they are actually needed, and
remove the sorting on multiple columns when a sort field is passed in.
We don't do this for the default sort, so let's not do it here either.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Not linked from anywhere just yet, but they are available if you know
they exist and can be used in the standard query string.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This adds a column similar to the flagged package count for the number
of signed packages in a given architecture or repository. It is up to
the user to do some simple math to figure out the number of unsigned
packages.
Also, add 'signed' as a hidden search field option similar to what we
did for packager.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
If our query returned zero results, then try a slightly less exclusive
query followed by returning a 404 result.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
We now have one link pointing to the tree of /trunk, and another
pointing to the log of /trunk. Both links specify a package branch.
Signed-off-by: Evangelos Foutras <evangelos@foutrelis.com>
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This was pointed out by the W3C validator.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Dan: fix usage of urlencode() function.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Comma-separated list.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Don't list pkgname twice, include pkgbase instead.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Just for fun and for people that know what they are doing.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This moves signoff creation and display to the new packages.Signoff
model.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This is another SQL-based utility method that dramatically cuts back on
how many queries we run and gets around the shortcoming of arbitrary
joins in Django. It will be used by the new signoff page logic.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This one is centered around pkgbase, much as our PackageRelation object
is. However, it also tracks all of the versioning fields we have in
order to making joining against the current package testing list
possible. Finally, additional metadata including a created date, an
(optional) revoke date, and a comments field are added.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This treats repo.staging special in much the way we already have to
treat repo.testing as special.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This is used from the developer dashboard to add a new column to the
stats of # of packages for a given developer where they were the last to
do the packaging.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
We had these two cases munged together before; some packages have seen
filelist updates but simply don't have any files ('firefox-i18n' for
example).
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
This is really annoying.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
For a Package object query, we almost always did .select_related('arch',
'repo). Refactor this into the manager as a 'normal()' method so we can
avoid sprinkling the same logic everywhere.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
These are retrieved by adding 'json/' to the normal package details or
files view.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
These were starting to get a bit too much inside the model itself, and
they don't really belong there as they are view layer concerns anyway.
Signed-off-by: Dan McGee <dan@archlinux.org>
|
|
Signed-off-by: Dan McGee <dan@archlinux.org>
|