Merge branch 'archweb' into archweb-generic2

4 files changed, 25 insertions, 16 deletions

diff --git a/main/log.py b/main/log.py
index 63634874..5c745cc8 100644
--- a/main/log.py
+++ b/main/log.py
@@ -46,7 +46,6 @@ class RateLimitFilter(object):
 
         trace = '\n'.join(traceback.format_exception(*record.exc_info))
         key = md5(trace).hexdigest()
-        duplicate = False
         cache = self.cache_module.cache
 
         # Test if the cache works
diff --git a/main/migrations/0029_fill_in_repo_data.py b/main/migrations/0029_fill_in_repo_data.py
index 0887b28c..7da6b1c4 100644
--- a/main/migrations/0029_fill_in_repo_data.py
+++ b/main/migrations/0029_fill_in_repo_data.py
@@ -7,7 +7,6 @@ from django.db import models
 class Migration(DataMigration):
 
     def forwards(self, orm):
-        "Write your forwards methods here."
         orm.Repo.objects.filter(name__istartswith='community').update(bugs_project=5, svn_root='community')
         orm.Repo.objects.filter(name__iexact='multilib').update(bugs_project=5, svn_root='community')
 
diff --git a/main/models.py b/main/models.py
index a561f4f6..2f4d3520 100644
--- a/main/models.py
+++ b/main/models.py
@@ -7,10 +7,9 @@ from django.db import models
 from django.db.models import Q
 from django.contrib.auth.models import User
 from django.contrib.sites.models import Site
-from django.utils.timezone import now
 
 from .fields import PositiveBigIntegerField
-from .utils import cache_function, set_created_field
+from .utils import set_created_field
 from devel.models import DeveloperKey
 from packages.alpm import AlpmAPI
 
@@ -140,7 +139,7 @@ class Package(models.Model):
     @property
     def signature(self):
         try:
-            data = b64decode(self.pgp_signature)
+            data = b64decode(self.pgp_signature.encode('utf-8'))
         except TypeError:
             return None
         if not data:
@@ -187,7 +186,6 @@ class Package(models.Model):
             self._applicable_arches = list(arches)
         return self._applicable_arches
 
-    #@cache_function(119)
     def get_requiredby(self):
         """
         Returns a list of package objects. An attempt will be made to keep this
@@ -195,14 +193,22 @@ class Package(models.Model):
         category as this package if that check makes sense.
         """
         from packages.models import Depend
+        sorttype = '''(CASE deptype
+        WHEN 'D' THEN 0
+        WHEN 'O' THEN 1
+        WHEN 'M' THEN 2
+        WHEN 'C' THEN 3
+        ELSE 1000 END)'''
         name_clause = '''packages_depend.name IN (
         SELECT %s UNION ALL
         SELECT z.name FROM packages_provision z WHERE z.pkg_id = %s
         )'''
         requiredby = Depend.objects.select_related('pkg',
                 'pkg__arch', 'pkg__repo').extra(
-                 where=[name_clause], params=[self.pkgname, self.id]).order_by(
-                'pkg__pkgname', 'pkg__arch__name', 'pkg__repo__name')
+                select={'sorttype': sorttype},
+                where=[name_clause], params=[self.pkgname, self.id]).order_by(
+                'sorttype', 'pkg__pkgname',
+                'pkg__arch__name', 'pkg__repo__name')
         if not self.arch.agnostic:
             # make sure we match architectures if possible
             requiredby = requiredby.filter(
@@ -265,7 +271,6 @@ class Package(models.Model):
             trimmed.append(dep)
         return trimmed
 
-    #@cache_function(121)
     def get_depends(self):
         """
         Returns a list of dicts. Each dict contains ('dep', 'pkg', and
@@ -276,7 +281,6 @@ class Package(models.Model):
         Packages will match the testing status of this package if possible.
         """
         deps = []
-        arches = None
         # TODO: we can use list comprehension and an 'in' query to make this
         # more effective
         for dep in self.depends.all():
@@ -293,7 +297,6 @@ class Package(models.Model):
             return (sort_order.get(dep.deptype, 1000), dep.name)
         return sorted(deps, key=sort_key)
 
-    #@cache_function(123)
     def reverse_conflicts(self):
         """
         Returns a list of packages with conflicts against this package.
@@ -403,13 +406,13 @@ class Package(models.Model):
         '''attempt to locate this package anywhere else, regardless of
         architecture or repository. Excludes this package from the list.'''
         names = [self.pkgname]
-        if self.pkgname.startswith('lib32-'):
+        if self.pkgname.startswith(u'lib32-'):
             names.append(self.pkgname[6:])
-        elif self.pkgname.endswith('-multilib'):
+        elif self.pkgname.endswith(u'-multilib'):
             names.append(self.pkgname[:-9])
         else:
-            names.append('lib32-' + self.pkgname)
-            names.append(self.pkgname + '-multilib')
+            names.append(u'lib32-' + self.pkgname)
+            names.append(self.pkgname + u'-multilib')
         return Package.objects.normal().filter(
                 pkgname__in=names).exclude(id=self.id).order_by(
                 'arch__name', 'repo__name')
diff --git a/main/utils.py b/main/utils.py
index cdd4ff71..9ee8db58 100644
--- a/main/utils.py
+++ b/main/utils.py
@@ -3,11 +3,11 @@ try:
 except ImportError:
     import pickle
 
-from datetime import datetime
 import hashlib
 
 from django.core.cache import cache
 from django.db import connections, router
+from django.http import HttpResponse
 from django.utils.timezone import now
 from django.template.defaultfilters import slugify
 
@@ -55,6 +55,14 @@ def clear_cache_function(func, args, kwargs):
     cache.delete(key)
 
 
+def empty_response():
+    empty = HttpResponse('')
+    # designating response as 'streaming' forces ConditionalGetMiddleware to
+    # not add a 'Content-Length: 0' header
+    empty.streaming = True
+    return empty
+
+
 def format_http_headers(request):
     headers = sorted((k, v) for k, v in request.META.items()
             if k.startswith('HTTP_'))