Merge commit 'f6d65'

# Conflicts:
#	skins/ArchLinux/ArchLinux.php

1 files changed, 51 insertions, 0 deletions

diff --git a/tests/phpunit/structure/AvailableRightsTest.php b/tests/phpunit/structure/AvailableRightsTest.php
new file mode 100644
index 00000000..51d31aaa
--- /dev/null
+++ b/tests/phpunit/structure/AvailableRightsTest.php
@@ -0,0 +1,51 @@
+<?php
+
+/**
+ * Try to make sure that extensions register all rights in $wgAvailableRights
+ * or via the 'UserGetAllRights' hook.
+ *
+ * @author Marius Hoch < hoo@online.de >
+ */
+class AvailableRightsTest extends PHPUnit_Framework_TestCase {
+
+	/**
+	 * Returns all rights that should be in $wgAvailableRights + all rights
+	 * registered via the 'UserGetAllRights' hook + all "core" rights.
+	 *
+	 * @return string[]
+	 */
+	private function getAllVisibleRights() {
+		global $wgGroupPermissions, $wgRevokePermissions;
+
+		$rights = User::getAllRights();
+
+		foreach( $wgGroupPermissions as $permissions ) {
+			$rights = array_merge( $rights, array_keys( $permissions ) );
+		}
+
+		foreach( $wgRevokePermissions as $permissions ) {
+			$rights = array_merge( $rights, array_keys( $permissions ) );
+		}
+
+		$rights = array_unique( $rights );
+		sort( $rights );
+
+		return $rights;
+	}
+
+	public function testAvailableRights() {
+		$missingRights = array_diff(
+			$this->getAllVisibleRights(),
+			User::getAllRights()
+		);
+
+		$this->assertEquals(
+			array(),
+			// Re-index to produce nicer output, keys are meaningless.
+			array_values( $missingRights ),
+			'Additional user rights need to be added to $wgAvailableRights or ' .
+			'via the "UserGetAllRights" hook. See the instructions at: ' .
+			'https://www.mediawiki.org/wiki/Manual:User_rights#Adding_new_rights'
+		);
+	}
+}