1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
|
<?php
/**
* Version of LockManager based on using redis servers.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @ingroup LockManager
*/
/**
* Manage locks using redis servers.
*
* Version of LockManager based on using redis servers.
* This is meant for multi-wiki systems that may share files.
* All locks are non-blocking, which avoids deadlocks.
*
* All lock requests for a resource, identified by a hash string, will map to one
* bucket. Each bucket maps to one or several peer servers, each running redis.
* A majority of peers must agree for a lock to be acquired.
*
* This class requires Redis 2.6 as it makes use Lua scripts for fast atomic operations.
*
* @ingroup LockManager
* @since 1.22
*/
class RedisLockManager extends QuorumLockManager {
/** @var Array Mapping of lock types to the type actually used */
protected $lockTypeMap = array(
self::LOCK_SH => self::LOCK_SH,
self::LOCK_UW => self::LOCK_SH,
self::LOCK_EX => self::LOCK_EX
);
/** @var RedisConnectionPool */
protected $redisPool;
/** @var Array Map server names to hostname/IP and port numbers */
protected $lockServers = array();
protected $session = ''; // string; random UUID
/**
* Construct a new instance from configuration.
*
* $config paramaters include:
* - lockServers : Associative array of server names to "<IP>:<port>" strings.
* - srvsByBucket : Array of 1-16 consecutive integer keys, starting from 0,
* each having an odd-numbered list of server names (peers) as values.
* - redisConfig : Configuration for RedisConnectionPool::__construct().
*
* @param Array $config
* @throws MWException
*/
public function __construct( array $config ) {
parent::__construct( $config );
$this->lockServers = $config['lockServers'];
// Sanitize srvsByBucket config to prevent PHP errors
$this->srvsByBucket = array_filter( $config['srvsByBucket'], 'is_array' );
$this->srvsByBucket = array_values( $this->srvsByBucket ); // consecutive
$config['redisConfig']['serializer'] = 'none';
$this->redisPool = RedisConnectionPool::singleton( $config['redisConfig'] );
$this->session = wfRandomString( 32 );
}
// @TODO: change this code to work in one batch
protected function getLocksOnServer( $lockSrv, array $pathsByType ) {
$status = Status::newGood();
$lockedPaths = array();
foreach ( $pathsByType as $type => $paths ) {
$status->merge( $this->doGetLocksOnServer( $lockSrv, $paths, $type ) );
if ( $status->isOK() ) {
$lockedPaths[$type] = isset( $lockedPaths[$type] )
? array_merge( $lockedPaths[$type], $paths )
: $paths;
} else {
foreach ( $lockedPaths as $type => $paths ) {
$status->merge( $this->doFreeLocksOnServer( $lockSrv, $paths, $type ) );
}
break;
}
}
return $status;
}
// @TODO: change this code to work in one batch
protected function freeLocksOnServer( $lockSrv, array $pathsByType ) {
$status = Status::newGood();
foreach ( $pathsByType as $type => $paths ) {
$status->merge( $this->doFreeLocksOnServer( $lockSrv, $paths, $type ) );
}
return $status;
}
protected function doGetLocksOnServer( $lockSrv, array $paths, $type ) {
$status = Status::newGood();
$server = $this->lockServers[$lockSrv];
$conn = $this->redisPool->getConnection( $server );
if ( !$conn ) {
foreach ( $paths as $path ) {
$status->fatal( 'lockmanager-fail-acquirelock', $path );
}
return $status;
}
$keys = array_map( array( $this, 'recordKeyForPath' ), $paths ); // lock records
try {
static $script =
<<<LUA
if ARGV[1] ~= 'EX' and ARGV[1] ~= 'SH' then
return redis.error_reply('Unrecognized lock type given (must be EX or SH)')
end
local failed = {}
-- Check that all the locks can be acquired
for i,resourceKey in ipairs(KEYS) do
local keyIsFree = true
local currentLocks = redis.call('hKeys',resourceKey)
for i,lockKey in ipairs(currentLocks) do
local _, _, type, session = string.find(lockKey,"(%w+):(%w+)")
-- Check any locks that are not owned by this session
if session ~= ARGV[2] then
local lockTimestamp = redis.call('hGet',resourceKey,lockKey)
if 1*lockTimestamp < ( ARGV[4] - ARGV[3] ) then
-- Lock is stale, so just prune it out
redis.call('hDel',resourceKey,lockKey)
elseif ARGV[1] == 'EX' or type == 'EX' then
keyIsFree = false
break
end
end
end
if not keyIsFree then
failed[#failed+1] = resourceKey
end
end
-- If all locks could be acquired, then do so
if #failed == 0 then
for i,resourceKey in ipairs(KEYS) do
redis.call('hSet',resourceKey,ARGV[1] .. ':' .. ARGV[2],ARGV[4])
-- In addition to invalidation logic, be sure to garbage collect
redis.call('expire',resourceKey,ARGV[3])
end
end
return failed
LUA;
$res = $conn->luaEval( $script,
array_merge(
$keys, // KEYS[0], KEYS[1],...KEYS[N]
array(
$type === self::LOCK_SH ? 'SH' : 'EX', // ARGV[1]
$this->session, // ARGV[2]
$this->lockTTL, // ARGV[3]
time() // ARGV[4]
)
),
count( $keys ) # number of first argument(s) that are keys
);
} catch ( RedisException $e ) {
$res = false;
$this->redisPool->handleException( $server, $conn, $e );
}
if ( $res === false ) {
foreach ( $paths as $path ) {
$status->fatal( 'lockmanager-fail-acquirelock', $path );
}
} else {
$pathsByKey = array_combine( $keys, $paths );
foreach ( $res as $key ) {
$status->fatal( 'lockmanager-fail-acquirelock', $pathsByKey[$key] );
}
}
return $status;
}
protected function doFreeLocksOnServer( $lockSrv, array $paths, $type ) {
$status = Status::newGood();
$server = $this->lockServers[$lockSrv];
$conn = $this->redisPool->getConnection( $server );
if ( !$conn ) {
foreach ( $paths as $path ) {
$status->fatal( 'lockmanager-fail-releaselock', $path );
}
return $status;
}
$keys = array_map( array( $this, 'recordKeyForPath' ), $paths ); // lock records
try {
static $script =
<<<LUA
if ARGV[1] ~= 'EX' and ARGV[1] ~= 'SH' then
return redis.error_reply('Unrecognized lock type given (must be EX or SH)')
end
local failed = {}
for i,resourceKey in ipairs(KEYS) do
local released = redis.call('hDel',resourceKey,ARGV[1] .. ':' .. ARGV[2])
if released > 0 then
-- Remove the whole structure if it is now empty
if redis.call('hLen',resourceKey) == 0 then
redis.call('del',resourceKey)
end
else
failed[#failed+1] = resourceKey
end
end
return failed
LUA;
$res = $conn->luaEval( $script,
array_merge(
$keys, // KEYS[0], KEYS[1],...KEYS[N]
array(
$type === self::LOCK_SH ? 'SH' : 'EX', // ARGV[1]
$this->session // ARGV[2]
)
),
count( $keys ) # number of first argument(s) that are keys
);
} catch ( RedisException $e ) {
$res = false;
$this->redisPool->handleException( $server, $conn, $e );
}
if ( $res === false ) {
foreach ( $paths as $path ) {
$status->fatal( 'lockmanager-fail-releaselock', $path );
}
} else {
$pathsByKey = array_combine( $keys, $paths );
foreach ( $res as $key ) {
$status->fatal( 'lockmanager-fail-releaselock', $pathsByKey[$key] );
}
}
return $status;
}
protected function releaseAllLocks() {
return Status::newGood(); // not supported
}
protected function isServerUp( $lockSrv ) {
return (bool)$this->redisPool->getConnection( $this->lockServers[$lockSrv] );
}
/**
* @param $path string
* @return string
*/
protected function recordKeyForPath( $path ) {
return implode( ':', array( __CLASS__, 'locks', $this->sha1Base36Absolute( $path ) ) );
}
/**
* Make sure remaining locks get cleared for sanity
*/
function __destruct() {
while ( count( $this->locksHeld ) ) {
foreach ( $this->locksHeld as $path => $locks ) {
$this->doUnlock( array( $path ), self::LOCK_EX );
$this->doUnlock( array( $path ), self::LOCK_SH );
}
}
}
}
|