1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
|
<?php
/**
* Helper class for update.php.
*
* Copyright © 2005 Brion Vibber <brion@pobox.com>
* https://www.mediawiki.org/
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @ingroup Maintenance
*/
/**
* Look for duplicate user table entries and optionally prune them.
*
* This is still used by our MysqlUpdater at:
* includes/installer/MysqlUpdater.php
*
* @ingroup Maintenance
*/
class UserDupes {
private $db;
private $reassigned;
private $trimmed;
private $failed;
private $outputCallback;
function __construct( &$database, $outputCallback ) {
$this->db = $database;
$this->outputCallback = $outputCallback;
}
/**
* Output some text via the output callback provided
* @param string $str Text to print
*/
private function out( $str ) {
call_user_func( $this->outputCallback, $str );
}
/**
* Check if this database's user table has already had a unique
* user_name index applied.
* @return bool
*/
function hasUniqueIndex() {
$info = $this->db->indexInfo( 'user', 'user_name', __METHOD__ );
if ( !$info ) {
$this->out( "WARNING: doesn't seem to have user_name index at all!\n" );
return false;
}
# Confusingly, 'Non_unique' is 0 for *unique* indexes,
# and 1 for *non-unique* indexes. Pass the crack, MySQL,
# it's obviously some good stuff!
return ( $info[0]->Non_unique == 0 );
}
/**
* Checks the database for duplicate user account records
* and remove them in preparation for application of a unique
* index on the user_name field. Returns true if the table is
* clean or if duplicates have been resolved automatically.
*
* May return false if there are unresolvable problems.
* Status information will be echo'd to stdout.
*
* @return bool
*/
function clearDupes() {
return $this->checkDupes( true );
}
/**
* Checks the database for duplicate user account records
* in preparation for application of a unique index on the
* user_name field. Returns true if the table is clean or
* if duplicates can be resolved automatically.
*
* Returns false if there are duplicates and resolution was
* not requested. (If doing resolution, edits may be reassigned.)
* Status information will be echo'd to stdout.
*
* @param bool $doDelete Pass true to actually remove things
* from the database; false to just check.
* @return bool
*/
function checkDupes( $doDelete = false ) {
if ( $this->hasUniqueIndex() ) {
echo wfWikiID() . " already has a unique index on its user table.\n";
return true;
}
$this->lock();
$this->out( "Checking for duplicate accounts...\n" );
$dupes = $this->getDupes();
$count = count( $dupes );
$this->out( "Found $count accounts with duplicate records on " . wfWikiID() . ".\n" );
$this->trimmed = 0;
$this->reassigned = 0;
$this->failed = 0;
foreach ( $dupes as $name ) {
$this->examine( $name, $doDelete );
}
$this->unlock();
$this->out( "\n" );
if ( $this->reassigned > 0 ) {
if ( $doDelete ) {
$this->out( "$this->reassigned duplicate accounts had edits "
. "reassigned to a canonical record id.\n" );
} else {
$this->out( "$this->reassigned duplicate accounts need to have edits reassigned.\n" );
}
}
if ( $this->trimmed > 0 ) {
if ( $doDelete ) {
$this->out( "$this->trimmed duplicate user records were deleted from "
. wfWikiID() . ".\n" );
} else {
$this->out( "$this->trimmed duplicate user accounts were found on "
. wfWikiID() . " which can be removed safely.\n" );
}
}
if ( $this->failed > 0 ) {
$this->out( "Something terribly awry; $this->failed duplicate accounts were not removed.\n" );
return false;
}
if ( $this->trimmed == 0 || $doDelete ) {
$this->out( "It is now safe to apply the unique index on user_name.\n" );
return true;
} else {
$this->out( "Run this script again with the --fix option to automatically delete them.\n" );
return false;
}
}
/**
* We don't want anybody to mess with our stuff...
* @access private
*/
function lock() {
$set = array( 'user', 'revision' );
$names = array_map( array( $this, 'lockTable' ), $set );
$tables = implode( ',', $names );
$this->db->query( "LOCK TABLES $tables", __METHOD__ );
}
function lockTable( $table ) {
return $this->db->tableName( $table ) . ' WRITE';
}
/**
* @access private
*/
function unlock() {
$this->db->query( "UNLOCK TABLES", __METHOD__ );
}
/**
* Grab usernames for which multiple records are present in the database.
* @return array
* @access private
*/
function getDupes() {
$user = $this->db->tableName( 'user' );
$result = $this->db->query(
"SELECT user_name,COUNT(*) AS n
FROM $user
GROUP BY user_name
HAVING n > 1", __METHOD__ );
$list = array();
foreach ( $result as $row ) {
$list[] = $row->user_name;
}
return $list;
}
/**
* Examine user records for the given name. Try to see which record
* will be the one that actually gets used, then check remaining records
* for edits. If the dupes have no edits, we can safely remove them.
* @param string $name
* @param bool $doDelete
* @access private
*/
function examine( $name, $doDelete ) {
$result = $this->db->select( 'user',
array( 'user_id' ),
array( 'user_name' => $name ),
__METHOD__ );
$firstRow = $this->db->fetchObject( $result );
$firstId = $firstRow->user_id;
$this->out( "Record that will be used for '$name' is user_id=$firstId\n" );
foreach ( $result as $row ) {
$dupeId = $row->user_id;
$this->out( "... dupe id $dupeId: " );
$edits = $this->editCount( $dupeId );
if ( $edits > 0 ) {
$this->reassigned++;
$this->out( "has $edits edits! " );
if ( $doDelete ) {
$this->reassignEdits( $dupeId, $firstId );
$newEdits = $this->editCount( $dupeId );
if ( $newEdits == 0 ) {
$this->out( "confirmed cleaned. " );
} else {
$this->failed++;
$this->out( "WARNING! $newEdits remaining edits for $dupeId; NOT deleting user.\n" );
continue;
}
} else {
$this->out( "(will need to reassign edits on fix)" );
}
} else {
$this->out( "ok, no edits. " );
}
$this->trimmed++;
if ( $doDelete ) {
$this->trimAccount( $dupeId );
}
$this->out( "\n" );
}
}
/**
* Count the number of edits attributed to this user.
* Does not currently check log table or other things
* where it might show up...
* @param int $userid
* @return int
* @access private
*/
function editCount( $userid ) {
return intval( $this->db->selectField(
'revision',
'COUNT(*)',
array( 'rev_user' => $userid ),
__METHOD__ ) );
}
/**
* @param int $from
* @param int $to
* @access private
*/
function reassignEdits( $from, $to ) {
$this->out( 'reassigning... ' );
$this->db->update( 'revision',
array( 'rev_user' => $to ),
array( 'rev_user' => $from ),
__METHOD__ );
$this->out( "ok. " );
}
/**
* Remove a user account line.
* @param int $userid
* @access private
*/
function trimAccount( $userid ) {
$this->out( "deleting..." );
$this->db->delete( 'user', array( 'user_id' => $userid ), __METHOD__ );
$this->out( " ok" );
}
}
|