diff options
| author | Dan McGee <dan@archlinux.org> | 2011-08-09 17:01:13 -0500 |
|---|---|---|
| committer | Lukas Fleischer <archlinux@cryptocrack.de> | 2011-08-10 14:34:07 +0200 |
| commit | 9a79d2105e2dea9876883da65a00d245d475bed2 (patch) | |
| tree | 3ae0b4d6e98d2b83b78df183929a8d6a386e96f1 /web/html/pkgsubmit.php | |
| parent | 1f79258e81207829c59f4a8fa4d44a32683e2a77 (diff) | |
Segment the upload directory by package name prefix
This implements the following scheme:
* /packages/cower/ --> /packages/co/cower/
* /packages/j/ --> /packages/j/j/
* /packages/zqy/ --> /packages/zq/zqy/
We take up to the first two characters of each package name as a
intermediate subdirectory, and then the full package name lives
underneath that. Shorter named packages live in a single letter
directory.
Why, you ask? Well because earlier today the AUR hit 32,000 entries in
the unsupported/ directory, making new package uploads impossible. While
some might argue we shouldn't have so many damn packages in the repos,
we should be able to handle this case.
Why two characters instead of one? Our two biggest two-char groups, 'pe'
and 'py', both start with 'p', and have nearly 2000 packages each. Go
Python and Perl.
Still needed is a "move the existing data" script, as well as a set of
rewrite rules for those wishing to preserve backward compatible URLs for
any helper programs doing the wrong thing and relying on them.
Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Diffstat (limited to 'web/html/pkgsubmit.php')
| -rw-r--r-- | web/html/pkgsubmit.php | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 793f8ca..d21e6ae 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -256,7 +256,7 @@ if ($uid): } if (isset($pkg_name)) { - $incoming_pkgdir = INCOMING_DIR . $pkg_name; + $incoming_pkgdir = INCOMING_DIR . substr($pkg_name, 0, 2) . "/" . $pkg_name; } if (!$error) { @@ -268,7 +268,8 @@ if ($uid): rm_tree($incoming_pkgdir); } - if (!@mkdir($incoming_pkgdir)) { + # The mode is masked by the current umask, so not as scary as it looks + if (!mkdir($incoming_pkgdir, 0777, true)) { $error = __( "Could not create directory %s.", $incoming_pkgdir); } } else { @@ -286,7 +287,7 @@ if ($uid): } if (!$error) { - if (!@chdir($incoming_pkgdir)) { + if (!chdir($incoming_pkgdir)) { $error = __("Could not change directory to %s.", $incoming_pkgdir); } |