summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArthur de Jong <arthur@arthurdejong.org>2013-01-05 22:55:56 +0000
committerArthur de Jong <arthur@arthurdejong.org>2013-01-05 22:55:56 +0000
commit086a1a586148eb9740a1dd4b2697faf2d06d87ca (patch)
tree14951b6f9b02642eccdf5f1e3f9f7a8e3d115eb7
parentc89c41b523dfeec992fde31f490d639adf7905a7 (diff)
change ethernet address formatting from FIXME to note
git-svn-id: http://arthurdejong.org/svn/nss-pam-ldapd/nss-pam-ldapd@1900 ef36b2f9-881f-0410-afb5-c4e39611909c
-rw-r--r--nslcd/ether.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/nslcd/ether.c b/nslcd/ether.c
index fc54b6d..bf8b084 100644
--- a/nslcd/ether.c
+++ b/nslcd/ether.c
@@ -5,7 +5,7 @@
Copyright (C) 1997-2005 Luke Howard
Copyright (C) 2006 West Consulting
- Copyright (C) 2006, 2007, 2009, 2010, 2011, 2012 Arthur de Jong
+ Copyright (C) 2006, 2007, 2009, 2010, 2011, 2012, 2013 Arthur de Jong
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
@@ -78,10 +78,10 @@ static int mkfilter_ether_byname(const char *name,
static int mkfilter_ether_byether(const char *addrstr,
char *buffer, size_t buflen)
{
- /* FIXME: this has a bug when the directory has 01:00:0e:...
- and we're looking for 1:0:e:... (leading zeros) */
+ /* Note: this only works if the address in LDAP has the preferred minimal
+ representation (e.g. 1:0:e:...) and not with extra leading zeros
+ (e.g. 01:00:0e:...) */
/* there should be no characters that need escaping */
- /* build filter */
return mysnprintf(buffer, buflen, "(&%s(%s=%s))",
ether_filter, attmap_ether_macAddress, addrstr);
}