code improvements by making type casts explicit, flagging ignored return values, renames and flagging of parameters and some miscelanious improvements (thanks to gcc warnings, splint, rats and flawfinder)

git-svn-id: http://arthurdejong.org/svn/nss-pam-ldapd/nss-ldapd@265 ef36b2f9-881f-0410-afb5-c4e39611909c

1 files changed, 5 insertions, 1 deletions

diff --git a/nslcd/ether.c b/nslcd/ether.c
index de8f7bc..249b426 100644
--- a/nslcd/ether.c
+++ b/nslcd/ether.c
@@ -75,6 +75,10 @@ struct ether
 #ifdef NEW
 static int write_ether(LDAPMessage *e,struct ldap_state *pvt,FILE *fp)
 {
+  /* FIXME: fix following problem:
+            if the entry has multiple cn fields we may end up
+            sending the wrong cn, we should return the requested
+            CN instead, otherwise write an entry for each cn */
   int stat;
   char buffer[1024];
   /* write NSLCD_STRING(ETHER_NAME) */
@@ -95,7 +99,7 @@ static int write_ether(LDAPMessage *e,struct ldap_state *pvt,FILE *fp)
 
 static enum nss_status
 _nss_ldap_parse_ether (LDAPMessage * e,
-                       struct ldap_state * pvt,
+                       struct ldap_state UNUSED(*pvt),
                        void *result, char *buffer, size_t buflen)
 {
   struct ether *ether = (struct ether *) result;