diff options
| author | Arthur de Jong <arthur@arthurdejong.org> | 2014-05-04 14:38:02 +0200 |
|---|---|---|
| committer | Arthur de Jong <arthur@arthurdejong.org> | 2014-05-04 14:57:09 +0200 |
| commit | 2274b41dcb6bbb2557ab0e4358a11f1d54da12d7 (patch) | |
| tree | 553de2872797d8ccf0d1316889e8d7d344f64d34 /nslcd/group.c | |
| parent | 15fc13ce31cd6455d7c64089425da795da5d51d2 (diff) | |
Make buffer size error logging consistent
This adds logging of most cases where a defined buffer is not large
enough to hold provided data on error log level.
Diffstat (limited to 'nslcd/group.c')
| -rw-r--r-- | nslcd/group.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/nslcd/group.c b/nslcd/group.c index 390e398..d7dfe42 100644 --- a/nslcd/group.c +++ b/nslcd/group.c @@ -94,7 +94,10 @@ static int mkfilter_group_byname(const char *name, char safename[BUFLEN_SAFENAME]; /* escape attribute */ if (myldap_escape(name, safename, sizeof(safename))) + { + log_log(LOG_ERR, "mkfilter_group_byname(): safename buffer too small"); return -1; + } /* build filter */ return mysnprintf(buffer, buflen, "(&%s(%s=%s))", group_filter, attmap_group_cn, safename); @@ -136,7 +139,10 @@ static int mkfilter_group_bymember(MYLDAP_SESSION *session, char safedn[BUFLEN_SAFEDN]; /* escape attribute */ if (myldap_escape(uid, safeuid, sizeof(safeuid))) + { + log_log(LOG_ERR, "mkfilter_group_bymember(): safeuid buffer too small"); return -1; + } /* try to translate uid to DN */ if ((strcasecmp(attmap_group_member, "\"\"") == 0) || (uid2dn(session, uid, dn, sizeof(dn)) == NULL)) @@ -144,7 +150,10 @@ static int mkfilter_group_bymember(MYLDAP_SESSION *session, group_filter, attmap_group_memberUid, safeuid); /* escape DN */ if (myldap_escape(dn, safedn, sizeof(safedn))) + { + log_log(LOG_ERR, "mkfilter_group_bymember(): safedn buffer too small"); return -1; + } /* also lookup using user DN */ return mysnprintf(buffer, buflen, "(&%s(|(%s=%s)(%s=%s)))", group_filter, @@ -158,7 +167,10 @@ static int mkfilter_group_bymemberdn(const char *dn, char safedn[BUFLEN_SAFEDN]; /* escape DN */ if (myldap_escape(dn, safedn, sizeof(safedn))) + { + log_log(LOG_ERR, "mkfilter_group_bymemberdn(): safedn buffer too small"); return -1; + } return mysnprintf(buffer, buflen, "(&%s(%s=%s))", group_filter, |