diff options
| author | Lennart Poettering <lennart@poettering.net> | 2013-11-21 19:34:37 +0100 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2013-11-21 21:12:36 +0100 |
| commit | ebcf1f97de4f6b1580ae55eb56b1a3939fe6b602 (patch) | |
| tree | def5185990acebac842ed8fca253531d88897a4a /TODO | |
| parent | 0ccad099d4c08dc5a16c87cdd6eefc05e9d4b670 (diff) | |
bus: rework message handlers to always take an error argument
Message handler callbacks can be simplified drastically if the
dispatcher automatically replies to method calls if errors are returned.
Thus: add an sd_bus_error argument to all message handlers. When we
dispatch a message handler and it returns negative or a set sd_bus_error
we send this as message error back to the client. This means errors
returned by handlers by default are given back to clients instead of
rippling all the way up to the event loop, which is desirable to make
things robust.
As a side-effect we can now easily turn the SELinux checks into normal
function calls, since the method call dispatcher will generate the right
error replies automatically now.
Also, make sure we always pass the error structure to all property and
method handlers as last argument to follow the usual style of passing
variables for return values as last argument.
Diffstat (limited to 'TODO')
| -rw-r--r-- | TODO | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -43,6 +43,8 @@ CGroup Rework Completion: Features: +* add API to clone sd_bus_message objects + * sd-bus: synthesized messages should get serial number (uint32_t) -1 * sd-event: allow multiple signal handlers per signal @@ -62,8 +64,6 @@ Features: * sd-bus: enforce signatures on response messages -* sd-bus: make message handlers take an sd_bus_error and generate error replies automatically if they are set - * sd-bus: see if we can drop more message validation on the sending side * sd-bus: introduce sd_bus_creds object and attach it to messages as well as allow querying it for names |