summaryrefslogtreecommitdiff
path: root/extra/kdelibs/fix-double-POST-action.patch
blob: 2672d65db13869972aecb87fa9a43e26d37e113b (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
commit 92db24adfa941003db1d885df01157056617f30b
Author: Maks Orlovich <maksim@kde.org>
Date:   Sun May 8 14:39:03 2011 -0400

    Fix the job-on-hold reuse logic, which caused the double-POST problem)
    
    adawit, could you please at least READ what you're backporting if you are
    going to be this aggressive? Or better yet, please don't backport anything
    that's not fixing a critical bug or is trivial, as per:
    http://techbase.kde.org/Policies/Minor_Point_Release_Policy
    
    CCMAIL: adawit@kde.org
    BUG: 272466

diff --git a/kio/kio/scheduler.cpp b/kio/kio/scheduler.cpp
index 55da053..9f5607e 100644
--- a/kio/kio/scheduler.cpp
+++ b/kio/kio/scheduler.cpp
@@ -1151,7 +1151,7 @@ Slave *SchedulerPrivate::heldSlaveForJob(SimpleJob *job)
         bool canJobReuse = (cmd == CMD_GET || cmd == CMD_MULTI_GET);
 
         if (KIO::TransferJob *tJob = qobject_cast<KIO::TransferJob *>(job)) {
-            canJobReuse = cmd == (canJobReuse || cmd == CMD_SPECIAL);
+            canJobReuse = (canJobReuse || cmd == CMD_SPECIAL);
             if (canJobReuse) {
                 KIO::MetaData outgoing = tJob->outgoingMetaData();
                 const QString resume = outgoing.value("resume");