diff options
author | Victor Lowther <victor.lowther@gmail.com> | 2010-06-07 07:19:54 -0500 |
---|---|---|
committer | Victor Lowther <victor.lowther@gmail.com> | 2010-07-11 19:01:27 -0500 |
commit | 4300436822ac740888bce3d3dbbfe845e32b9305 (patch) | |
tree | f70a978f62a49136aabd15a5841e33b56a6823dc /functions | |
parent | 597a4d96665b63705124bb9be5c71534f4b5bf0f (diff) |
Clean up status() function.
Calling your args with $* will do nasty things if any of your args
has a space in it. "$@" will always do The Right Thing.
Just test the command directly, don't run it and then grab its exit value.
Diffstat (limited to 'functions')
-rw-r--r-- | functions | 8 |
1 files changed, 3 insertions, 5 deletions
@@ -123,14 +123,12 @@ stat_die() { status() { stat_busy "$1" shift - $* >/dev/null 2>&1 - if [ $? -eq 0 ]; then + if "$@" >/dev/null 2>&1; then stat_done return 0 - else - stat_fail - return 1 fi + stat_fail + return 1 } # usage : in_array( $needle, $haystack ) |