summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrion Vibber <brion@pobox.com>2010-02-08 19:22:55 -0800
committerBrion Vibber <brion@pobox.com>2010-02-08 19:22:55 -0800
commitbc4e843f396dc450b04b612e7de14246084469d1 (patch)
treee3a14e6e3d94128b98e48fe3a1e80e56449eb53b
parent96ef4435b61570dbbf15d921a42543bfb13786c0 (diff)
Disable deprecated 'since' parameter on public_timeline API; causes performance problems. (since_id will work cleanly)
-rw-r--r--actions/apitimelinepublic.php6
1 files changed, 5 insertions, 1 deletions
diff --git a/actions/apitimelinepublic.php b/actions/apitimelinepublic.php
index 3f4a46c0f..0fb0788e9 100644
--- a/actions/apitimelinepublic.php
+++ b/actions/apitimelinepublic.php
@@ -74,6 +74,10 @@ class ApiTimelinePublicAction extends ApiPrivateAuthAction
parent::prepare($args);
$this->notices = $this->getNotices();
+
+ if ($this->since) {
+ throw new ServerException("since parameter is disabled for performance; use since_id", 403);
+ }
return true;
}
@@ -145,7 +149,7 @@ class ApiTimelinePublicAction extends ApiPrivateAuthAction
$notice = Notice::publicStream(
($this->page - 1) * $this->count, $this->count, $this->since_id,
- $this->max_id, $this->since
+ $this->max_id
);
while ($notice->fetch()) {